emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Litvinov Sergey <slitvinov@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH][babel] add a string input to ob-octave
Date: Sat, 01 Oct 2011 09:10:30 +0200	[thread overview]
Message-ID: <87bou1faqh.fsf@gmail.com> (raw)
In-Reply-To: <87r52xmuri.fsf@gmail.com> (Litvinov Sergey's message of "Sat, 01 Oct 2011 02:16:01 +0200")

Hello,

Litvinov Sergey <slitvinov@gmail.com> writes:

> +    (cond
> +     ((stringp var)
> +      (format "\'%s\'" (or var "nil")))
> +     (t
> +      (format "%s" (or var "nil"))))))

Just nitpicking:

In the first case, var is already identified as a string, so it will
always be non-nil, and your "or" is useless.

In the second case, (or var "nil") is redundant, as (format "%s" nil)
already returns "nil".

In other words, replacing (or var "nil") with var would be enough in
both cases.

Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2011-10-01  7:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-01  0:16 Litvinov Sergey
2011-10-01  7:10 ` Nicolas Goaziou [this message]
2011-10-01 11:49   ` Litvinov Sergey
2011-10-06 14:49     ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bou1faqh.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=slitvinov@gmail.com \
    --subject='Re: [PATCH][babel] add a string input to ob-octave' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).