emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@altern.org>
To: Paul <emacs-orgmode@lookmumnohands.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-capture, removing whitespace from new captures
Date: Sat, 29 Oct 2011 14:08:52 +0200	[thread overview]
Message-ID: <87bot080ff.fsf@gnu.org> (raw)
In-Reply-To: <20110914111415.GE15861@shift> (Paul's message of "Wed, 14 Sep 2011 21:14:15 +1000")

Hi Paul,

Paul <emacs-orgmode@lookmumnohands.net> writes:

> In fact adding whitespace-cleanup to org-capture-before-finalize-hook
> was what I tried first, but it didn't do what I wanted.  This hook is
> called _after_ the buffer is widened - making whitespace-cleanup
> operate on the _entire_ buffer, not just the newly added capture.
>
> I believe the patch is still required - I should have explained
> org-capture-before-finalize-hook's behaviour more explicitly in my
> original submission.

I'm willing to apply this patch -- could you provide it with a
well-formatted ChangeLog entry?

Thanks!

> Further to this, can anybody suggest a better documentation string for
> org-capture-before-finalize-hook?  (Preferably in tandem with my
> proposed patch.)  Currently it is:
>
>     Hook that is run right before a capture process is finalized.
>     The capture buffer is still current when this hook runs.
>
> I feel the "finalized" part is somewhat ambiguous.  What it means is
> "after the capture buffer is widened, and before it is saved".  I
> expected it to mean "BEFORE the capture buffer is widened".
>
> Maybe:
>     Hook that is run after the capture buffer is widened and prior to
>     being finalized.  The capture buffer is still current when this
>     hook runs.

Thanks for the suggestion -- I've updated the docstring like this:

  "Hook that is run right before a capture process is finalized.
   The capture buffer is still current when this hook runs and it is
   widened to the entire buffer."

The convention is that the first sentence should be readable on one
single line.  

Best,

-- 
 Bastien

next prev parent reply	other threads:[~2011-10-29 12:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-13 21:19 [PATCH] org-capture, removing whitespace from new captures paulusm
2011-09-14  8:44 ` Olaf Dietsche
2011-09-14 11:14   ` Paul
2011-09-14 12:59     ` Olaf Dietsche
2011-10-29 12:08     ` Bastien [this message]
2012-02-18 15:50       ` David Maus
2012-02-18 17:19         ` Bastien
2012-02-18 17:33           ` David Maus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bot080ff.fsf@gnu.org \
    --to=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=emacs-orgmode@lookmumnohands.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).