From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: Possible bug in org-cycle with property drawer Date: Sun, 29 Jan 2012 10:53:35 +0100 Message-ID: <87bopmrg0w.fsf@gnu.org> References: <8502.1327506516@alphaville> <87aa5bdaug.fsf@gnu.org> <8796.1327508273@alphaville> <87ipjyg886.fsf@gnu.org> <8739b2weid.fsf@Rainer.invalid> <87sjiztmit.fsf@altern.org> <87r4yjrl1k.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([140.186.70.92]:59385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrRQv-0003LO-TM for emacs-orgmode@gnu.org; Sun, 29 Jan 2012 04:52:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RrRQu-0008Lq-KQ for emacs-orgmode@gnu.org; Sun, 29 Jan 2012 04:52:25 -0500 Received: from mail-we0-f169.google.com ([74.125.82.169]:39827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RrRQu-0008Lm-Bn for emacs-orgmode@gnu.org; Sun, 29 Jan 2012 04:52:24 -0500 Received: by wera13 with SMTP id a13so2966371wer.0 for ; Sun, 29 Jan 2012 01:52:23 -0800 (PST) In-Reply-To: <87r4yjrl1k.fsf@Rainer.invalid> (Achim Gratz's message of "Sun, 29 Jan 2012 09:05:11 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Achim Gratz writes: > Bastien writes: >> This is quite a hypothetical case: the default value for `org-drawers' >> contains drawers that are hardcoded and correspond to key features: I >> cannot figure out a good reason for *not* having these drawers in the >> configuration. > > As a customized variable org-drawers can have any content the user > choses, including none. Before your change, the documentation said that > drawers can be _defined_ (not added) on a per-file-basis. Past your > change, documentation now says that drawers can be _added_ on a per-file > basis (minor nit: org-drawers is no longer the corresponding variable to > a file-local setting, but the basis onto which the file-local-setting is > appended). Yes, you're right, and you put it very well. If there is anything that you can suggest to enhance the documentation here, please do. `org-drawers' contains the default drawers for all files, and #+DRAWERS lets the user add new drawers on top of these default drawers. E.g. if a user have a "HIDE" drawer that he wants to use in any Org buffer, it's a good idea to put it in `org-drawers'. If there is a buffer-local drawer he want just for one file, it's a good idea to add it using #+DRAWERS. > Existing documents will still define _all_ drawers, not just > the additional ones, however it seems you add them without checking if > they are already present (I'd think add-to-list would be better than > append). Fixed, thanks. > Now, there might be a good reason to have system drawers that the user > can't change easily, but then they should not be defined in org-drawers, > perhaps? I suggest this: (defconst org-persistent-drawers '(...)) (defcustom org-custom-drawers '(...)) Then local value of org-drawers would be computed by combining the two (with duplicates deletion.) Would that be consistent to you? -- Bastien