From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [PATCH] Fix inconsistency in drawer handling Date: Sat, 15 Sep 2012 14:36:15 +0200 Message-ID: <87boh7layo.fsf@gmail.com> References: <1347710412-23188-1-git-send-email-yann.hodique@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:53204) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCrfX-0004b9-Uu for emacs-orgmode@gnu.org; Sat, 15 Sep 2012 08:40:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TCrfW-0007vc-Vo for emacs-orgmode@gnu.org; Sat, 15 Sep 2012 08:40:19 -0400 Received: from mail-wi0-f177.google.com ([209.85.212.177]:38948) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TCrfW-0007uZ-PB for emacs-orgmode@gnu.org; Sat, 15 Sep 2012 08:40:18 -0400 Received: by wibhn17 with SMTP id hn17so681349wib.12 for ; Sat, 15 Sep 2012 05:40:18 -0700 (PDT) In-Reply-To: <1347710412-23188-1-git-send-email-yann.hodique@gmail.com> (Yann Hodique's message of "Sat, 15 Sep 2012 14:00:11 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Yann Hodique Cc: emacs-orgmode@gnu.org Hello, Yann Hodique writes: > I've noticed that drawers are not managed similarly, depending on the > workflow. More precisely, the end-of-drawer detection is not exactly > the same for various exports, org-element, or folding. It all boils > down to variations around (re-search-forward ":END:"). > > In particular, it's expected that property drawers for taskjuggler > export will contain an :end: key (which is arguably a bad idea by > itself), that fools some other parts of org. > > This patch is an attempt at making drawers handling more predictable. This patch is good, but I'd rather hard-code the regexp within org-element: I'm slowly trying to make this library as low-level as possible. Do you mind changing it? Thank you. Regards, -- Nicolas Goaziou