emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Yann Hodique <yann.hodique@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix inconsistency in drawer handling
Date: Sat, 15 Sep 2012 14:36:15 +0200	[thread overview]
Message-ID: <87boh7layo.fsf@gmail.com> (raw)
In-Reply-To: <1347710412-23188-1-git-send-email-yann.hodique@gmail.com> (Yann Hodique's message of "Sat, 15 Sep 2012 14:00:11 +0200")

Hello,

Yann Hodique <yann.hodique@gmail.com> writes:

> I've noticed that drawers are not managed similarly, depending on the
> workflow. More precisely, the end-of-drawer detection is not exactly
> the same for various exports, org-element, or folding. It all boils
> down to variations around (re-search-forward ":END:").
>
> In particular, it's expected that property drawers for taskjuggler
> export will contain an :end: key (which is arguably a bad idea by
> itself), that fools some other parts of org.
>
> This patch is an attempt at making drawers handling more predictable.

This patch is good, but I'd rather hard-code the regexp within
org-element: I'm slowly trying to make this library as low-level as
possible. Do you mind changing it?

Thank you.


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2012-09-15 12:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-15 12:00 [PATCH] Fix inconsistency in drawer handling Yann Hodique
2012-09-15 12:00 ` Yann Hodique
2012-09-15 12:36 ` Nicolas Goaziou [this message]
2012-09-16 17:03   ` Yann Hodique
2012-09-19 14:02     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87boh7layo.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=yann.hodique@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).