emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@altern.org>
To: Jambunathan K <kjambunathan@gmail.com>
Cc: Achim Gratz <Stromeko@nexgo.de>, emacs-orgmode@gnu.org
Subject: Re: Compilation problem
Date: Tue, 18 Sep 2012 15:22:17 +0200	[thread overview]
Message-ID: <87boh331py.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87wr01sdsu.fsf@gmail.com> (Jambunathan K.'s message of "Tue, 11 Sep 2012 04:09:29 +0530")

Hi Jambunathan,

Jambunathan K <kjambunathan@gmail.com> writes:

> Please ask for clarification and politely indicate that a change may
> have to be reverted.  

Sorry that I reverted this one too hastily and without warning.

> Instead of the commit being wrong, is it possible that
> changes were incomplete.  

I understand.

What would be helpful would be some comment in the commit telling 
that the change is part of a bigger change that is not yet committed.

But I think we should try to avoid this: the whole point of using git 
is to commit changes only if they are complete.  A "change" can be a
commit or a set of commits, but let's try to push changes only when
they are complete.

I know this is not always easy, and I'm not lecturing here, I'm just
sharing directions I try to follow myself.

Thanks,

-- 
 Bastien

next prev parent reply	other threads:[~2012-09-18 13:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-10 12:29 Compilation problem Alan Schmitt
2012-09-10 19:45 ` Achim Gratz
2012-09-10 19:56   ` John Hendy
2012-09-11  6:29   ` Alan Schmitt
2012-09-10 19:52 ` Nick Dokos
2012-09-10 20:11   ` Achim Gratz
2012-09-10 20:14     ` Bastien
2012-09-10 20:21       ` Achim Gratz
2012-09-10 20:23         ` Bastien
2012-09-10 22:39           ` Jambunathan K
2012-09-18 13:22             ` Bastien [this message]
2012-09-18 13:28               ` Carsten Dominik
2012-09-18 14:23                 ` Bastien
2012-09-10 20:27         ` Nick Dokos
2012-09-11  6:32       ` Alan Schmitt
2012-09-18 14:29 ` Bastien
2012-09-18 15:39   ` Alan Schmitt
2012-09-18 20:00     ` Achim Gratz
2012-09-19  7:28       ` Alan Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87boh331py.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    --cc=kjambunathan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).