From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: org-unmodified asks to revert buffer if file was modified outside emacs Date: Sat, 23 Feb 2013 11:33:45 +0100 Message-ID: <87bobb2tn7.fsf@bzg.ath.cx> References: <87txqiibjj.fsf@yahoo.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:42835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9CnU-0000nS-J6 for emacs-orgmode@gnu.org; Sat, 23 Feb 2013 05:57:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U9CnS-0002Xw-Mf for emacs-orgmode@gnu.org; Sat, 23 Feb 2013 05:57:40 -0500 Received: from mail-wg0-f44.google.com ([74.125.82.44]:64704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U9CnS-0002Xq-GQ for emacs-orgmode@gnu.org; Sat, 23 Feb 2013 05:57:38 -0500 Received: by mail-wg0-f44.google.com with SMTP id dr12so1150636wgb.23 for ; Sat, 23 Feb 2013 02:57:37 -0800 (PST) In-Reply-To: <87txqiibjj.fsf@yahoo.fr> (Nicolas Richard's message of "Tue, 15 Jan 2013 18:46:56 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Nicolas Richard Cc: emacs-orgmode@gnu.org Hi Nicolas, "Nicolas Richard" writes: > Short story is : if you call org-agenda-list and some agenda files have > been modified outside emacs (e.g. by some revision control system), the > command fails if the user choose to revert the file when asked, leaving > a blank agenda in which 'g' does not work. Does it need a fix ? Which > fix ? Good questions. I think it's acceptable to get this warning when an agenda file has been changed outside of Emacs. But having it twice is clearly wrong. The problems lies in `org-agenda-prepare-buffers' which modifies the properties of agenda files. The deeper problem comes from Emacs, as IMHO changing the properties of the buffer should be fine even when the file has been changed outside, because the text properties of the buffer are part of the buffer, not of the file. remove-text-properties, set-text-properties etc. always ask for a confirmation when the underlying file has been changed outside Emacs. So for now I don't know how to fix this in Org. I will ping Emacs developers for the rational behind the current behavior of remove-text-properties and friends. Thanks, -- Bastien