From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: org-agenda-write taking very long (probably because of babel) Date: Thu, 28 Feb 2013 09:56:53 +0100 Message-ID: <87bob4g6ju.fsf@bzg.ath.cx> References: <2013-02-27T17-53-25@devnull.Karl-Voit.at> <87y5e9icwc.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([208.118.235.92]:38369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UAzIO-0002lI-JH for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 03:56:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UAzIN-0002uf-Bp for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 03:56:56 -0500 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:64388) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UAzIN-0002to-6D for emacs-orgmode@gnu.org; Thu, 28 Feb 2013 03:56:55 -0500 Received: by mail-we0-f172.google.com with SMTP id x10so1276293wey.31 for ; Thu, 28 Feb 2013 00:56:54 -0800 (PST) In-Reply-To: <87y5e9icwc.fsf@Rainer.invalid> (Achim Gratz's message of "Wed, 27 Feb 2013 23:56:51 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Hi Achim, Achim Gratz writes: > * lisp/ob-core.el (org-babel-execute-src-block): Do not ask for > confirmation if the cached result is current. Since > `org-babel-confirm-evaluate´ does additional things besides asking > for confirmation, call it first with `org-confirm-babel-evaluate´ > bound to nil. This has the effect that it will never ask the user, > but will indicate if the block should be evaluated. If yes, > determine whether the cached result block is current (this is > deferred until now since `org-babel-process-params´ might trigger > expensive operations). If `cache-current-p´ is t or > `org-confirm-babel-evaluate´ is nil, evaluate the source block > without asking. In case the cache is current the evaluation will > not actually do anything but return the cached value, so this is > safe. In case `org-confirm-babel-evaluate´ is nil the user would > not be asked anyway, so the call of `org-babel-confirm-evaluate´ is > not necessary. Otherwise run `org-babel-confirm-evaluate´ again to > ask permission from the user and act depending on the answer. Sorry to nitpick on this but please keep the Emacs-like change log small, if not terse. Additionnal details are more than welcome in the commit message though. Thanks! -- Bastien