From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Fix several byte-compile warnings in org-contrib files Date: Wed, 03 Apr 2013 13:13:23 +0200 Message-ID: <87bo9vj298.fsf@bzg.ath.cx> References: <1364783083-3175-1-git-send-email-aaronecay@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:51031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNLdA-0001lG-EB for emacs-orgmode@gnu.org; Wed, 03 Apr 2013 07:13:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNLd9-0001dS-3G for emacs-orgmode@gnu.org; Wed, 03 Apr 2013 07:13:28 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:47988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNLd8-0001dL-TM for emacs-orgmode@gnu.org; Wed, 03 Apr 2013 07:13:27 -0400 Received: by mail-wi0-f180.google.com with SMTP id c10so1381187wiw.13 for ; Wed, 03 Apr 2013 04:13:26 -0700 (PDT) In-Reply-To: <1364783083-3175-1-git-send-email-aaronecay@gmail.com> (Aaron Ecay's message of "Sun, 31 Mar 2013 22:24:43 -0400") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Aaron Ecay Cc: emacs-orgmode@gnu.org Hi Aaron, Aaron Ecay writes: > * contrib/lisp/org-bibtex-extras.el: convert to using cl-lib functions > (obe-bibtex-file), > (obe-html-link-base): add a 'group argument to defcustoms > (obe-citations): replace non-existent org-babel-clean-text-properties > with org-no-properties > * contrib/lisp/org-git-link.el: add an eval-and-compile to avoid > undefined function warnings > (org-git-show): use with-current-buffer instead of > save-excursion+set-buffer I applied some of the changes above: http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=137fd3 http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=69eb39 Thanks! Please help us with the Changelog formatting, there are many tiny issues with your changelogs -- see details: http://orgmode.org/worg/org-contribute.html#sec-5 Best, -- Bastien