emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Rasmus <rasmus@gmx.us>
To: alan.schmitt@polytechnique.org
Cc: emacs-orgmode@gnu.org
Subject: Re: small koma bug
Date: Mon, 10 Mar 2014 14:24:56 +0100	[thread overview]
Message-ID: <87bnxep4nr.fsf@gmx.us> (raw)
In-Reply-To: <m2k3c2e945.fsf@polytechnique.org> (Alan Schmitt's message of "Mon, 10 Mar 2014 09:44:10 +0100")

Hi Alan,

Alan Schmitt <alan.schmitt@polytechnique.org> writes:

> I think I have found a small bug in ox-koma-letter, but to fix it I
> would like your input.
>
> The bug: if "from-address" is not specified in the file, then it will be
> set unconditionally to the empty string, even if it is specified in an
> lco file.

OK.  AFAIK it's OK to leave out the fromaddress and fromname.

> The reason of the bug is as follows.
>
> To set up the from address, we call this:
>
> #+begin_src emacs-lisp
>    (let ((from-address (org-koma-letter--determine-to-and-from info 'from)))
>      (and from-address (format "\\setkomavar{fromaddress}{%s}\n" from-address)))
> #+end_src

How about:

   (let ((from-address (org-koma-letter--determine-to-and-from info 'from)))
     (and (org-string-nw-p from-address) (format "\\setkomavar{fromaddress}{%s}\n" from-address)))

Or more explicitly

   (let ((from-address (org-koma-letter--determine-to-and-from info 'from)))
     (when (org-string-nw-p from-address) (format "\\setkomavar{fromaddress}{%s}\n" from-address)))

> This uses this function:
> #+begin_src emacs-lisp
> (defun org-koma-letter--determine-to-and-from (info key)
>   "Given INFO determine KEY for the letter.
> KEY should be `to' or `from'.
>
> `ox-koma-letter' allows two ways to specify TO and FROM.  If both
> are present return the preferred one as determined by
> `org-koma-letter-prefer-special-headings'."
>   (let ((option (plist-get info (if (eq key 'to) :to-address :from-address)))
> 	(headline (org-koma-letter--get-tagged-contents key)))
>     (replace-regexp-in-string
>      "\n" "\\\\\\\\\n"
>      (org-trim
>       (or (if (plist-get info :special-headings) (or headline option)
> 	    (or option headline))
> 	  ;; Fallback values.
> 	  (if (eq key 'to) "\\mbox{}" org-koma-letter-from-address))))))
> #+end_src

I guess org-koma-letter-from-address can be left empty, but for
instance 'to must have a value different from the empty string to not
create a LaTeX error.  As I said above, quick testing suggest this is
not necessary for fromaddress.

> As the empty string is considered as "true", we apply the format
> function in the first code block.

See below.

> I would suggest to have "org-koma-letter-from-address" begin "nil" as
> default. My question is: is it an allowed value for a string?

You can use org-string-nw-p to test is S is only white-space.  When
Nicolas cleaned the file he made all (or most?) defaults into strings,
so let's stick with that.

Let me know if your happy with this.

—Rasmus

-- 
Summon the Mothership!

next prev parent reply	other threads:[~2014-03-10 13:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10  8:44 small koma bug Alan Schmitt
2014-03-10 13:24 ` Rasmus [this message]
2014-03-10 13:50   ` Alan Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnxep4nr.fsf@gmx.us \
    --to=rasmus@gmx.us \
    --cc=alan.schmitt@polytechnique.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).