From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: "Valery V. Vorotyntsev" <valery.vv@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Bug: numeric org-clock-into-drawer is ignored [8.3beta (release_8.3beta-846-g38ab8b @ /Users/vvv/lib/emacs/org-mode/lisp/)]
Date: Sat, 28 Feb 2015 19:28:10 +0100 [thread overview]
Message-ID: <87bnkd6gcl.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAKuDaCxc09aZ2XKTSQTUXmHSmSy809kTh2xG7ZfE5TOmLBYCYg@mail.gmail.com> (Valery V. Vorotyntsev's message of "Fri, 27 Feb 2015 23:30:44 +0200")
Hello,
"Valery V. Vorotyntsev" <valery.vv@gmail.com> writes:
> On 27 February 2015 at 23:20, Valery V. Vorotyntsev <valery.vv@gmail.com> wrote:
>
>> I have set `org-clock-into-drawer' to 2.
>> `(org-clock-into-drawer)' should return the same value (see the
>> documentation of this function), yet it returns "LOGBOOK".
>
> Proposed patch:
>
> ----------[ begin ]----------
> diff --git a/lisp/org-clock.el b/lisp/org-clock.el
> index 07f02b0..0edc1b9 100644
> --- a/lisp/org-clock.el
> +++ b/lisp/org-clock.el
> @@ -88,6 +88,7 @@ Return value is either a string, an integer, or nil."
> (if (org-string-match-p "\\`[0-9]+\\'" p) (string-to-number p) p))
> ((org-string-nw-p org-clock-into-drawer))
> ((not org-clock-into-drawer) nil)
> + ((wholenump org-clock-into-drawer) org-clock-into-drawer)
> ((org-log-into-drawer))
> (t "LOGBOOK"))))
> ----------[ end ]----------
This was fixed recently. You need to update Org. Thank you for the patch
anyway.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2015-02-28 18:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-27 21:20 Bug: numeric org-clock-into-drawer is ignored [8.3beta (release_8.3beta-846-g38ab8b @ /Users/vvv/lib/emacs/org-mode/lisp/)] Valery V. Vorotyntsev
2015-02-27 21:30 ` Valery V. Vorotyntsev
2015-02-28 18:28 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bnkd6gcl.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=valery.vv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).