From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [patch, koma-letter] Change of subject behavior Date: Wed, 18 Mar 2015 00:08:23 +0100 Message-ID: <87bnjr1au0.fsf@nicolasgoaziou.fr> References: <87d247h6eo.fsf@gmx.us> <87wq2f1gqz.fsf@nicolasgoaziou.fr> <87mw3bdyv4.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YY0Zu-0003DW-3Q for emacs-orgmode@gnu.org; Tue, 17 Mar 2015 19:07:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YY0Zq-0006to-O2 for emacs-orgmode@gnu.org; Tue, 17 Mar 2015 19:07:14 -0400 Received: from relay6-d.mail.gandi.net ([2001:4b98:c:538::198]:58149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YY0Zq-0006tK-IN for emacs-orgmode@gnu.org; Tue, 17 Mar 2015 19:07:10 -0400 In-Reply-To: <87mw3bdyv4.fsf@gmx.us> (rasmus@gmx.us's message of "Tue, 17 Mar 2015 23:48:31 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Rasmus Cc: emacs-orgmode@gnu.org Rasmus writes: > Nicolas Goaziou writes: >> However, I don't think :opening setting belongs to >> `org-koma-letter-headline', as it means it is potentially set each time >> a headline is being processed. > > The property is at most set once cf. the second clause. By "potentially set", I meant the (trivial) check would be done nonetheless, which is a waste. >> Another (smallish) advantage is that the following case would be >> allowed: >> >> ***** Dear myself, >> * Part 1 > > Is the advantage that it won't fold? No, since * Dear myself, * Part 1 won't fold either, but in "****** Dear myself," stands out and doesn't look like a standard container. > I updated the patch. Perhaps the loop determination shod be moved to a > separate function to keep the template clean. Yes, it needs to be factored out (maybe `org-koma-letter--special-headline-p') since it is also used in `org-koma-letter-headline'. What about (defun org-koma-letter--special-headline-p (h info) (let ((special-tags (plist-get info :special-tags))) (org-some (lambda (tag) (assoc-string tag special-tags)) (org-export-get-tags h info)))) > I thinking this cause we (or at least I) sometimes point to > ox-koma-letter as an example of a derived backend. WDTY on that? What do you mean? > + (:with-headline-opening nil nil org-koma-letter-headline-is-opening-maybe) I don't think this line is required. Regards,