emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] org-src.el: Unescape source block on edit
Date: Fri, 22 May 2015 21:04:10 +0200	[thread overview]
Message-ID: <87bnhc3045.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87617lgqsh.fsf@kmlap.domain.org> (Kyle Meyer's message of "Fri, 22 May 2015 00:49:34 -0400")

Hello,

Kyle Meyer <kyle@kyleam.com> writes:

> org-edit-src-code doesn't seem to be unescaping correctly.  For
> example, calling org-edit-src-code on
>
> #+begin_src org
>   ,* h
> #+end_src
>
> puts ",* h", not "* h", in the source buffer.  When exiting, ",*" is
> escaped again, resulting in
>
> #+begin_src org
>   ,,* h
> #+end_src
>
> The attached patch moves the unescaping call from org-edit-src-code to
> org-src--edit-element so that the source string is unescaped
> regardless of whether it was passed as an argument or extracted
> directly from the buffer.

Thanks. However, this wouldn't work as `org-src--edit-element' is called
on elements that doesn't need escaping, e.g., a footnote definition.

Anyway, it is fixed in 71641bc3a0882bb16fb2b62ebef8ebc98ba0e3d8.


Regards,

-- 
Nicolas Goaziou

  reply	other threads:[~2015-05-22 19:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22  4:49 [PATCH] org-src.el: Unescape source block on edit Kyle Meyer
2015-05-22 19:04 ` Nicolas Goaziou [this message]
2015-05-22 20:22   ` Kyle Meyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnhc3045.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).