From: Daimrod <daimrod@gmail.com>
To: Daniel Borchmann <daniel.borchmann@tu-dresden.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: Filters lost after reviving buried, sticky agenda
Date: Sun, 21 Jun 2015 17:47:02 +0200 [thread overview]
Message-ID: <87bng9rrm1.fsf@gmail.com> (raw)
In-Reply-To: <877fssro5z.fsf@tu-dresden.de> (Daniel Borchmann's message of "Fri, 01 May 2015 23:19:36 +0200")
[-- Attachment #1.1: Type: text/plain, Size: 1905 bytes --]
Daniel Borchmann <daniel.borchmann@tu-dresden.de> writes:
> Dear all,
>
> I regularly lose all my filters when I bury a sticky agenda and revive
> it later. In that case, the variable `org-agenda-tag-filter' is set to
> nil, although it was non-nil before burying.
>
> I played around a bit, and found out that `org-agenda-tag-filter' is
> buffer-local (which is not a surprise). When the agenda buffer is
> revived, the function `org-agenda-prepare' is called, which, among
> others, should reset the filters (provided that
> `org-agenda-persistent-filter' is set). The beginning of the function
> is
>
> --->8---
> (defun org-agenda-prepare (&optional name)
> (let ((filter-alist (if org-agenda-persistent-filter
> (list `(tag . ,org-agenda-tag-filter)
> `(re . ,org-agenda-regexp-filter)
> `(car . ,org-agenda-category-filter)))))
> ...))
> ---8<---
>
> It seems to me that `org-agenda-tag-filter' is read *before* the old
> agenda buffer is poped up (i.e., made current), and thus results in a
> `nil' value. Indeed, if I replace the definition of `filter-alist' by
>
> --->8---
> (let ((filter-alist (if org-agenda-persistent-filter
> (with-current-buffer
> (get-buffer org-agenda-buffer-name)
> (list `(tag . ,org-agenda-tag-filter)
> `(re . ,org-agenda-regexp-filter)
> `(car . ,org-agenda-category-filter))))))
> ...)
> ---8<---
>
> then the bug (seems to) disappear.
>
> My question is now: is this correct, or did I understand something
> wrong? If my understanding is correct, how this bug be fixed more
> elegantly?
It doesn't work at startup when agenda hasn't been built yet. The
following patch does seem to fix that. If it's ok, I can push it.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-lisp-org-agenda.el-Fix-non-persistent-filters-when-r.patch --]
[-- Type: text/x-diff, Size: 1494 bytes --]
From d2e8fef81585c249f33fa37260f6228709a67017 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gr=C3=A9goire=20Jadi?= <gregoire.jadi@univ-nantes.fr>
Date: Fri, 12 Jun 2015 17:35:30 +0200
Subject: [PATCH] lisp/org-agenda.el : Fix non-persistent filters when
refreshing sticky agenda
* lisp/org-agenda.el (org-agenda-prepare): Fix non-persistent filters when refreshing sticky agenda
When a sticky agenda is buried, then reviving and refreshing, existing
filters are ignored even when org-agenda-persistent-filter is `t'.
Reported and fixed by Daniel Borchmann
---
lisp/org-agenda.el | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index f5d1022..3a1f5bc 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -3642,10 +3642,11 @@ FILTER-ALIST is an alist of filters we need to apply when
(defun org-agenda-prepare (&optional name)
(let ((filter-alist (if org-agenda-persistent-filter
- (list `(tag . ,org-agenda-tag-filter)
- `(re . ,org-agenda-regexp-filter)
- `(effort . ,org-agenda-effort-filter)
- `(car . ,org-agenda-category-filter)))))
+ (with-current-buffer
+ (get-buffer-create org-agenda-buffer-name)
+ (list `(tag . ,org-agenda-tag-filter)
+ `(re . ,org-agenda-regexp-filter)
+ `(car . ,org-agenda-category-filter))))))
(if (org-agenda-use-sticky-p)
(progn
(put 'org-agenda-tag-filter :preset-filter nil)
--
1.9.1
[-- Attachment #1.3: Type: text/plain, Size: 30 bytes --]
Best,
--
Daimrod/Greg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-06-21 15:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 21:19 Filters lost after reviving buried, sticky agenda Daniel Borchmann
2015-06-21 15:47 ` Daimrod [this message]
2015-06-21 18:40 ` Daniel Borchmann
2015-06-22 4:11 ` Daimrod
2015-06-22 15:09 ` Subhan Michael Tindall
2015-06-22 13:27 ` Nick Dokos
2015-06-23 8:47 ` Daimrod
2015-06-23 9:15 ` Daimrod
2015-06-23 21:35 ` Nicolas Goaziou
2015-06-24 7:54 ` Daimrod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bng9rrm1.fsf@gmail.com \
--to=daimrod@gmail.com \
--cc=daniel.borchmann@tu-dresden.de \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).