emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: "Grégoire Jadi" <gregoire.jadi@univ-nantes.fr>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Fix `org-capture-templates' type declaration
Date: Sun, 25 Oct 2015 14:34:50 +0100	[thread overview]
Message-ID: <87bnbngjgl.fsf@univ-nantes.fr> (raw)
In-Reply-To: <87fv0zbast.fsf@nicolasgoaziou.fr>

[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]


Nicolas Goaziou writes:

> Hello,

Hi,

Thanks for the reply.

> Grégoire Jadi <gregoire.jadi@univ-nantes.fr> writes:
>
>> The attached patch fix the type declaration of org-capture-templates by
>> allowing the user to use file, variable, function and sexp as target's
>> file to match the documentation
>
> Thank you.
>
>> -				(file :tag "  File"))
>> +				(choice :tag "  File"
>> +					file variable function sexp))
>
> Shouldn't there be an entry for each type instead of stuffing everything
> within "File" descriptor ?

With my patch, the customization interface looks like this
- for a file :
Target location: Value Menu File:
  File: Value Menu File: ~/org/notes.org

- for a variable :
Target location: Value Menu File:
  File: Value Menu Variable: nil

- for a function :
Target location: Value Menu File:
  File: Value Menu Function: ignore

- for an Emacs Lisp form :
Target location: Value Menu File:
  File: Value Menu Lisp expression: nil

What kind of rendering do you think would be better/clearer?

Best,
> Regards,

-- 
Grégoire Jadi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

next prev parent reply	other threads:[~2015-10-25 13:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-24 17:43 [PATCH] Fix `org-capture-templates' type declaration Grégoire Jadi
2015-10-25  8:40 ` Nicolas Goaziou
2015-10-25 13:34   ` Grégoire Jadi [this message]
2015-10-25 15:44     ` Nicolas Goaziou
2015-10-25 16:47       ` Grégoire Jadi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bnbngjgl.fsf@univ-nantes.fr \
    --to=gregoire.jadi@univ-nantes.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).