From: Tobias Getzner <tobias.getzner@gmx.de>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org.el: fix org--get-outline-path-1
Date: Mon, 29 Feb 2016 20:04:57 +0100 [thread overview]
Message-ID: <87bn6zuyli.fsf@gmx.de> (raw)
In-Reply-To: <87io17zg58.fsf@nicolasgoaziou.fr>
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
> Tobias Getzner <tobias.getzner@gmx.de> writes:
>
>> Headline titles may be empty, in which case the respective match group
>> will be nil. This would throw an error when trying to regexp-replace
>> checkbox cookies.
>
> Indeed. Thank you for the report. I applied a slightly different fix,
> tho.
Thanks for fixing!
>> TODO: Depending on preference, a place-holder string might be a better
>> choice (for user-display) rather than leaving the outline-path element
>> empty.
>
> This makes sense. Maybe something like "[Empty]". WDYT?
[Empty] seems good to me.
Regards,
Tobias
prev parent reply other threads:[~2016-02-29 19:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 14:35 [PATCH] org.el: fix org--get-outline-path-1 Tobias Getzner
2016-02-29 15:32 ` Nicolas Goaziou
2016-02-29 19:04 ` Tobias Getzner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bn6zuyli.fsf@gmx.de \
--to=tobias.getzner@gmx.de \
--cc=emacs-orgmode@gnu.org \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).