From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kyle Meyer Subject: Re: [PATCH] Add option to automatically align tags in agenda view Date: Mon, 07 Aug 2017 13:32:39 -0400 Message-ID: <87bmnrthag.fsf@kyleam.com> References: <87poc7o50r.fsf@alphapapa.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1deltY-0001JO-I2 for emacs-orgmode@gnu.org; Mon, 07 Aug 2017 13:32:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1deltT-0006dG-F1 for emacs-orgmode@gnu.org; Mon, 07 Aug 2017 13:32:48 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:63602 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1deltT-0006cs-8v for emacs-orgmode@gnu.org; Mon, 07 Aug 2017 13:32:43 -0400 In-Reply-To: <87poc7o50r.fsf@alphapapa.net> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Adam Porter , emacs-orgmode@gnu.org Adam Porter writes: [...] > + (org-agenda-tags-column (pcase org-agenda-tags-column > + ('auto (- (window-text-width))) I believe that `auto is needed instead of 'auto because the latter will fail with Emacs versions earlier than Emacs 25. Though ... > + (otherwise org-agenda-tags-column))) ... with just one case and a fallthrough, I'd prefer you test with eq rather than using pcase. -- Kyle