emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bernt Hansen <bernt@norang.ca>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: Org Mode List <emacs-orgmode@gnu.org>,
	Allen Li <darkfeline@felesatra.moe>
Subject: Re: Bug: org-toggle-tag always marks buffer modified [9.1.13 (9.1.13-elpaplus @ .emacs.d/elpa/org-plus-contrib-20180618/)]
Date: Tue, 19 Jun 2018 10:32:50 -0400	[thread overview]
Message-ID: <87bmc6q225.fsf@norang.ca> (raw)
In-Reply-To: <877emvi5o5.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Tue, 19 Jun 2018 09:42:02 +0200")

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Allen Li <darkfeline@felesatra.moe> writes:
>
>> org-toggle-tag always marks the buffer as modified due to how it is
>> implemented.  It would be better if it did not mark the buffer
>> modified if it does not change anything.  This is annoying for
>> org-depend.el (which is contrib, not officially supported) because the
>> org-blocker-hook set by org-depend.el will mark the buffer modified
>> whenever an agenda view is built/refreshed.
>
> Fixed. Thank you.

Hi Nicholas,

This fix breaks my capture templates.

commit 593058e4a6270f52fdede2b871a0ee6504944f13
Author: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Date:   Tue Jun 19 09:40:00 2018 +0200

    `org-set-tags' modifies buffer only when necessary

    * lisp/org.el (org--align-tags-here):
    (org-set-tags): Modify buffer only when necessary.

    * testing/lisp/test-org.el (test-org/set-tags): Add tests.

    Reported-by: Allen Li <darkfeline@felesatra.moe>
    <http://lists.gnu.org/r/emacs-orgmode/2018-06/msg00242.html>



I have reverted it locally and it works again.

My normal TODO capture template doesn't allow SPC to separate words when
entering the new headline for the task.

The relevant capture template entry is

(setq org-capture-templates
      (quote (("t" "Todo" entry (file "C:/D-Drive/org/refile.org")
             "* TODO %?\n%U\n\n%x\n" :clock-in t :clock-resume t)
...

After opening the capture window and point is moved to the %? position I
type the headline but SPC no longer enters a space.  C-v SPC works but
that is inconvenient.

Thanks,
Bernt

next prev parent reply	other threads:[~2018-06-19 14:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-18 21:07 Bug: org-toggle-tag always marks buffer modified [9.1.13 (9.1.13-elpaplus @ .emacs.d/elpa/org-plus-contrib-20180618/)] Allen Li
2018-06-19  7:42 ` Nicolas Goaziou
2018-06-19 14:32   ` Bernt Hansen [this message]
2018-06-19 22:44     ` Bernt Hansen
2018-06-21 20:29       ` Bernt Hansen
2018-06-22 16:51         ` Nicolas Goaziou
2018-06-25  2:24           ` Bernt Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmc6q225.fsf@norang.ca \
    --to=bernt@norang.ca \
    --cc=darkfeline@felesatra.moe \
    --cc=emacs-orgmode@gnu.org \
    --cc=mail@nicolasgoaziou.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).