From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: Agenda search: setting sort-order Date: Tue, 19 Jun 2018 22:20:11 +0200 Message-ID: <87bmc6edfo.fsf@nicolasgoaziou.fr> References: Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50039) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVN6x-0002nA-3J for emacs-orgmode@gnu.org; Tue, 19 Jun 2018 16:20:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVN6t-0004Kj-1K for emacs-orgmode@gnu.org; Tue, 19 Jun 2018 16:20:19 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:47539) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVN6s-0004JP-Q0 for emacs-orgmode@gnu.org; Tue, 19 Jun 2018 16:20:14 -0400 In-Reply-To: (Nathan Neff's message of "Mon, 18 Jun 2018 13:16:41 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Nathan Neff Cc: emacs-orgmode Hello, Nathan Neff writes: > I had a look at org-agenda.el, and took a first stab at "coding" :) > I fixed the sorting problem when using agenda-search-view, and > I have a DIFF/patch at the bottom of this e-mail [1] that provided the fix. > > Would this be of interest to the org-mode project? IMO, the Org mode project is interested in having its bugs fixed ;) > This code fixes the > problem, > but it is duplicated in the function org-agenda-get-todos, and seems > redundant, > therefore a more "long term" fix would probably not resemble the minor patch > below. Also, I have no experience with lisp, nor the org-mode > codebase :-O A more "long term" fix would be to rewrite the agenda (asynchronous, more scalable, better API for external use). > Here's steps I used to find the problem. Feel free to skip to [1] > for the DIFF/patch. Would you mind sending it using `git format-patch'? Thank you. Regards, -- Nicolas Goaziou