emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: Fix C-u C-c C-q (align all tags in visible buffer)
Date: Fri, 04 Jan 2019 14:17:53 +0100	[thread overview]
Message-ID: <87bm4wv9xa.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <CAFyQvY2uVJ4M0HvzY95s9woP1suGE2WRYuSdyt4+Y3OMhStYhA@mail.gmail.com> (Kaushal Modi's message of "Thu, 3 Jan 2019 17:30:04 -0500")

Hello,

Kaushal Modi <kaushal.modi@gmail.com> writes:

> This minor bug had been bothering me for a while and I eventually got to
> looking into the source code for it.
>
> As of current master, C-u C-c C-q doesn't work as in the doc-string i.e.
> "When optional argument ALL is non-nil, align all tags in the visible part
> of the buffer.".
>
> Here's an example Org buffer:
>
> =====
> * Foo :abc:
> ** Bar :def:
> =====
>
> - With point on Foo heading, C-u C-c C-q aligns only :def: tag (tags from
> *next* heading onwards).
> - So when point is on Bar, no tags get aligned.
>
> Though I remember that C-u C-c C-q worked quite some time back.
>
> A commit in Apr 28, 2018 broke that behavior in
> https://code.orgmode.org/bzg/org-mode/commit/1615261cdc5da6dbe50176d7958c775d6d54411e#diff-f9a90d66b3053f60bd4e8d63f214273067d0d28L14288
> .
>
> While I don't understand that entire commit, this simple fix brings back
> the true C-u C-c C-q behavior:
>
> diff --git a/lisp/org.el b/lisp/org.el
> index db3c11b5f..b8daa3bfc 100644
> --- a/lisp/org.el
> +++ b/lisp/org.el
> @@ -14203,8 +14203,10 @@ visible part of the buffer."
>      (org--align-tags-here (funcall get-indent-column))
>        (save-excursion
>      (if all
> +            (progn
> +              (goto-char (point-min))
>            (while (re-search-forward org-tag-line-re nil t)
> -          (org--align-tags-here (funcall get-indent-column)))
> +            (org--align-tags-here (funcall get-indent-column))))
>        (org-back-to-heading t)
>        (org--align-tags-here (funcall get-indent-column)))))))
>
>
> If this looks good, I can commit this to maint and master.

Sure. Please also provide a regression test for it.

Thank you.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2019-01-04 13:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-03 22:30 Fix C-u C-c C-q (align all tags in visible buffer) Kaushal Modi
2019-01-04 13:17 ` Nicolas Goaziou [this message]
2019-01-04 14:01   ` Kaushal Modi
2019-01-04 14:17     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm4wv9xa.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=kaushal.modi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).