emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@gnu.org>
To: Anthony Carrico <acarrico@memebeam.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Include missing files when sitemap style is tree
Date: Sat, 24 Oct 2020 14:21:16 +0200	[thread overview]
Message-ID: <87blgrke6b.fsf@gnu.org> (raw)
In-Reply-To: <393d0ddf-894a-6183-c1fd-d8ab23a2163a@memebeam.org> (Anthony Carrico's message of "Fri, 11 Sep 2020 23:26:33 -0400")

Hi Anthony,

Anthony Carrico <acarrico@memebeam.org> writes:

> * ox-publish.el (org-publish-sitemap): Include files that have an 
> ancestor below base-directory with no published files and sitemap style 
> is tree.

thanks for the patch and sorry for the delay in replying.  I'm not
sure I understand the bug it fixes: can you briefly describe it or
provide a reproducible recipe?

> +(defun org-publish-dir-name-parent (dir-name)
> +  (file-name-as-directory (expand-file-name (concat dir-name ".."))))
> +
> +(defun org-publish-dir-name-and-parents (dir-name root-dir-name)
> +  (pcase dir-name
> +     ("" nil)
> +     ((or "./" "/" (pred (string= root-dir-name))) (list dir-name))
> +     (_ (cons dir-name (org-publish-dir-name-and-parents
> +			(org-publish-dir-name-parent dir-name) root-dir-name)))))
> +
> +(defun org-publish-file-name-parents (file root)
> +  (org-publish-dir-name-and-parents (file-name-directory file)
> +				    (file-name-as-directory root)))
> +

You would need to add docstrings for each of the new functions.

Thanks,

-- 
 Bastien

next prev parent reply	other threads:[~2020-10-24 12:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-12  3:26 [PATCH] Include missing files when sitemap style is tree Anthony Carrico
2020-10-24 12:21 ` Bastien [this message]
2020-10-27  0:38   ` Anthony Carrico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blgrke6b.fsf@gnu.org \
    --to=bzg@gnu.org \
    --cc=acarrico@memebeam.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).