From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id HiusBle71V85SAAA0tVLHw (envelope-from ) for ; Sun, 13 Dec 2020 06:57:27 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6GnjAVe71V/hDwAAB5/wlQ (envelope-from ) for ; Sun, 13 Dec 2020 06:57:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 918CD940355 for ; Sun, 13 Dec 2020 06:57:26 +0000 (UTC) Received: from localhost ([::1]:47146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1koLJr-0003qQ-R2 for larch@yhetil.org; Sun, 13 Dec 2020 01:57:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53940) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koLJ7-0003oh-7G for emacs-orgmode@gnu.org; Sun, 13 Dec 2020 01:56:37 -0500 Received: from out0.migadu.com ([2001:41d0:2:267::]:42310) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1koLJ3-000578-Vb for emacs-orgmode@gnu.org; Sun, 13 Dec 2020 01:56:36 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kyleam.com; s=key1; t=1607842589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DaadHlPGmjYg+kNJ6DdbCELszyVKO5iwUILFjObcyKQ=; b=rBXQmmzOn4jkUgL1RVrJVdNyTuTqP+bU+xAeuQL+zqzwE9tt/rVdklqmHkjCX+Pq04eLNF +zGmZMOU2D++o09XdmjANqAwe07rY9QO+UPvhA0HCELs8fe1fSvFP/HRBaRsuMiBc3EClw oR/QvBBOh3zDPBPtR7qrhiUnBdwJDM3+ICobkR7CeFjX5TIsbiLH4H5njR7QRPgwiqdndu K8m8qxLfldNbMCJ9+9Oq+RiOhG05LWGa43cLb49J/xEFdIJef4PJne1PpLwVjRr0irEtEX X11TPf7Rw/OEsQPowGQ3y3+/Q6nz4d9NmEBpqEO9lRX5mt1URIuUz0sv8I2RZw== From: Kyle Meyer To: Fatih Aydin Subject: Re: [PATCH] Margin added for overflow visibility problem In-Reply-To: References: Message-ID: <87bleyurc3.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Auth-User: kyle@kyleam.com Date: Sun, 13 Dec 2020 06:56:29 GMT Received-SPF: pass client-ip=2001:41d0:2:267::; envelope-from=kyle@kyleam.com; helo=out0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.50 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kyleam.com header.s=key1 header.b=rBXQmmzO; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 918CD940355 X-Spam-Score: -2.50 X-Migadu-Scanner: scn1.migadu.com X-TUID: taDBzFYckayc Fatih Aydin writes: > Write a code block in an org file and publish it to a html file. You > will see that only bottom part of the name of the programming language > is visible when you hover on it because of the css of that block > (overflow:auto) > To fix this, a margin-top can be added. Ah, that's a nice visual improvement. Thanks! To more closely follow conventions for commit messages in this project [1], I'd suggest to rewrite the message to something like this: --8<---------------cut here---------------start------------->8--- Subject: [PATCH] ox-html: Add margin to fix overflow visibility problem * lisp/ox-html.el (org-html-style-default): Add the margin-top property to pre.src:hover:before so that the programming language is fully visible. TINYCHANGE --8<---------------cut here---------------end--------------->8--- Does that look okay to you? If so, I can amend your commit when applying. (I'll wait a few more days for any CSS gurus on the list to weigh in.) [1] https://orgmode.org/worg/org-contribute.html#commit-messages