From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id aKDSC5Z2amELHwEAgWs5BA (envelope-from ) for ; Sat, 16 Oct 2021 08:52:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id 0F9uB5Z2amEUBgAAbx9fmQ (envelope-from ) for ; Sat, 16 Oct 2021 06:52:06 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 08D18F843 for ; Sat, 16 Oct 2021 08:51:56 +0200 (CEST) Received: from localhost ([::1]:38700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbdXu-0002zK-M0 for larch@yhetil.org; Sat, 16 Oct 2021 02:51:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbdXV-0002z6-1k for emacs-orgmode@gnu.org; Sat, 16 Oct 2021 02:51:29 -0400 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]:46834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mbdXR-00044X-8I for emacs-orgmode@gnu.org; Sat, 16 Oct 2021 02:51:28 -0400 Received: by mail-pg1-x529.google.com with SMTP id m21so10604679pgu.13 for ; Fri, 15 Oct 2021 23:51:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=sO2u2idSKJNElxZSczb2TbeP1TKBOYbPlXYRRBsxGE0=; b=qRougV8Te4VRGMc7CLaipgFM2vacyiYb7ZEhEX0jq/0wLEvuGSW97i4HhTjFkIwnWf eD9tNbpTpNpHCttNuT+uUUn167D6zkY4Qtqy7MTjGu3w9h6FLmWPh4KSFX4VtRyYitRG VoALwGuGacifGX6tKfX/9oFNWW/vqTMzphPOZ+D1ukXUdH0HblsI/p7EhVkfupX1vIZX W3io0dd0FAPg833YFvY0VG4zlag0EBUjrPfSGuX3MWkioVa/T34uoLjUB2HsZXP0XNZZ r8F7269wd2hYmquA9iJ6JG/Yf7z6fr19++25Zc5DC3ocWBh6myELf+arZVqIcHYR1fcU iaTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=sO2u2idSKJNElxZSczb2TbeP1TKBOYbPlXYRRBsxGE0=; b=gwjQ5f0myXMVaQRgDXaPhKRW9OsBLX8hOxHR1ylSbi8Kv+GCSwpqO2XBSKl8XLAFXs i5ypGaYIr4VP+3L185p/iNym3tsprSp7QQ4ZErvxFGE/t4kSZUXu1SdH3mNIi7EW9dZ4 hTcbSuLHxJyhVxMiFilcB4SM25C1kRam8E7i2/7ewnS63gp7lbGpm5/HUlHjKP2ivVpQ X/AxHAelhzX5vnDXqJn7pvyxuAqqhqTXPU+fxLVdoIAU7DmeJ0uftnEV2t6r6AKK26F2 vztWMTum6PXApbRPHO/ziRrm1hc3MaETANVXWrK6LWVZ3HT0RIsxkATTBFCTGFDj2DND Ob1w== X-Gm-Message-State: AOAM532yhnH44yr0LLZAtnTQo1vUtWsl4Q76/XPa0vZSR24UFOUhN7l1 R4K05dTIuO85XhFZBSYYYGs= X-Google-Smtp-Source: ABdhPJyhIEzq8PAXfKEh0wLUP3PEnRfyBVqLaNZrYpB0QwJzHUVDlV80um3LuN5di45AbdBxoVvPRg== X-Received: by 2002:a62:3102:0:b0:44b:63db:fc88 with SMTP id x2-20020a623102000000b0044b63dbfc88mr16319701pfx.75.1634367080890; Fri, 15 Oct 2021 23:51:20 -0700 (PDT) Received: from localhost ([103.125.234.62]) by smtp.gmail.com with ESMTPSA id j8sm6432913pfe.105.2021.10.15.23.51.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Oct 2021 23:51:20 -0700 (PDT) From: Ihor Radchenko To: Max Nikulin Subject: Re: [PATCH] [BUG] Org 9.5: org-goto UI seems broken In-Reply-To: References: <87mtnovv7f.fsf@alphapapa.net> <87h7dvy70t.fsf@localhost> <87ee8zxwic.fsf@localhost> <878rz3ddet.fsf@gmail.com> <87czoaug5x.fsf@gmail.com> <87o87tso54.fsf@localhost> <87pms9mf7v.fsf@gmail.com> <878ryx14sd.fsf@ucl.ac.uk> <87fst46ifa.fsf@gmail.com> <87h7djdi7k.fsf@localhost> Date: Sat, 16 Oct 2021 14:52:42 +0800 Message-ID: <87bl3pcvgl.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=yantar92@gmail.com; helo=mail-pg1-x529.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 0.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 08D18F843 X-Spam-Score: 0.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: k3pWjGny3h8Y Max Nikulin writes: > It seems, each case of `org-no-popups' may require specific code. I have > tried to take some code related to completion. It overrides > display-buffer-base-action, but something more is required for > pop-up-frames. I think you went too far. display-buffer-base-action is mostly for user to specify. We should not override it. If user needs adjustments for *Org Help*, it is always possible using a custom function inside display-buffer-base-action. I do not think that we need to do this job for the user. >From my perspective, there is no need to prevent users from shooting their own leg (we are in Emacs after all). The cases we may need to interfere are: (1) when some user customisations are mostly ok, except they affect Org's usability, and the user has no easy way to fix it; (2) when some customisation is very common and we significantly help many users by supporting such customisation in Org itself. I think pop-up-windows customisation qualifies for "(1)". Not display-buffer-base-action. Best, Ihor