From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8JAoEAgNXWNM2QAAbAwnHQ (envelope-from ) for ; Sat, 29 Oct 2022 13:22:48 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id cKU1DwgNXWOV3wAAG6o9tA (envelope-from ) for ; Sat, 29 Oct 2022 13:22:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A5C6FDF1C for ; Sat, 29 Oct 2022 13:22:47 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oojuT-0008NS-DP; Sat, 29 Oct 2022 07:21:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oojuR-0008Lb-A5 for emacs-orgmode@gnu.org; Sat, 29 Oct 2022 07:21:51 -0400 Received: from mout-p-102.mailbox.org ([80.241.56.152]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1oojuP-000666-CO for emacs-orgmode@gnu.org; Sat, 29 Oct 2022 07:21:51 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4Mzxnh51MBz9sdM; Sat, 29 Oct 2022 13:21:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kraus.my; s=MBO0001; t=1667042504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TCQiw91p4VDYIXbRq90xyezhIhO1eQptJerIhedlbo8=; b=R6tMsOIASxOHVAX6cUaPklBM1ZelbwOs+B+jxyU1WK2LvaphuyHOHJX7zaq06oL12dxFkq vC/vRZVhtfrNw5q5esXRk+i0IaK5KttwmaLo6cZIB/ipLx0qLJDUb76LtSYo4WJhOqui7x vYQPvVlaHkv1PaPWoZ5898kFGc/Bi1QlMeI4xvaJ/s/smNO53uCrHgAdRQGh+gct/kmrMf IuyIjw9It0kismNwq8I3k/so5ZFy+h11KZjWZYPl6//p7cIpHG+k55pelM+bd+DNLaLNNq jcWq4c6srHLyqrX1g0spx7mUphgvPN1N9uKUHREjEPlV3uU67Fxv1wf0F90frQ== References: <87o7tvi35b.fsf@localhost> From: Daniel Kraus To: Ihor Radchenko Cc: numbchild@gmail.com, emacs-orgmode@gnu.org Subject: Re: [PATCH] Fix ob-clojure handling source block variable's value is a org-mode table or list Date: Sat, 29 Oct 2022 13:18:28 +0200 In-reply-to: <87o7tvi35b.fsf@localhost> Message-ID: <87bkpu98ov.fsf@kraus.my> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=80.241.56.152; envelope-from=daniel@kraus.my; helo=mout-p-102.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Emacs-orgmode" Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1667042567; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TCQiw91p4VDYIXbRq90xyezhIhO1eQptJerIhedlbo8=; b=pFbvbfe1n9vxjMuTHHhv69OBLDRjzIdPEG9QXBDeko+b4gI0e8kQp+TcufcnCWnvtDHUN6 dhUzgfg/ZCOF04DQqv+P3P5BDzv4akudP/I0+i2etaOueLxN8R+YvCcYZr6yBcCTgYaNC9 o6bva8+8pyqZHwpuiJvlFi0cNcAgQ+70lFl16fladR5xen1g2vPT7HWHwJEbjC0xWxVbpu tJkme+UR9pDOrQ3N3v3/9CJfQpzHTr+BtyVVDhhX2ir4JdTh/BIxe/XgSoCzkO4PFdZQlF RJPMc7Z7oSmcjvx/Z8TG6ymdh0T6jMCMs8gtQvh3Bkqw/hUoNJ5hrQQ+x4mcNA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1667042567; a=rsa-sha256; cv=none; b=gClSZ+qRXGTBim/0lUyy8NtfV2e++pG52mdiT48CLH83MTfi8VmuqNBdRlf0egJJGk7S0K t3WK+KANEogYkPo/ps9gNRUOEhqOw6T4z0NzPt14tdFCDzDwEta6zX097kAjgFnhmEVCQ2 vk36XGc87TwDbgMA4A/hGZe9gR0Ah+EISLz6Uk3/wYaqRUOmq+M+Ex/4Q43L8oO3LhUCpH rIFUE20bdKHbBqP49qTI8yJ5/HfSvGDXvZxRpVaysvUtRo9EavvdzAZidZd/udWwHvJTez 9kkNseeN5zWLrwjzbQ9Kl38+T2n7ftjfQvuCxVSn2I4yYvDbK7KE2Idr++nm2Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=kraus.my header.s=MBO0001 header.b=R6tMsOIA; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.03 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=kraus.my header.s=MBO0001 header.b=R6tMsOIA; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A5C6FDF1C X-Spam-Score: -2.03 X-Migadu-Scanner: scn1.migadu.com X-TUID: DE5y+OeWMwF+ Hi Ihor Radchenko writes: > "Christopher M. Miles" writes: >> Any review comments about this patch? > I have sent the following comment shortly after your followup: I even made another post after that, suggesting that the if condition is not even needed. Simply always quoting seems to work and is also the way it's done in `ob-lisp.el`. See https://list.orgmode.org/orgmode/874jvp9wsg.fsf@kraus.my/ This simple patch is also already installed. Can you test if that works for you? And in case you missed it, I made another reply for you bug report about inline comments. Check https://list.orgmode.org/orgmode/878rl1a1e0.fsf@kraus.my/ Thanks, Daniel