From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id cKp5B/3ZcmPCfQEAbAwnHQ (envelope-from ) for ; Tue, 15 Nov 2022 01:14:53 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id aP9yB/3ZcmOgNAEA9RJhRA (envelope-from ) for ; Tue, 15 Nov 2022 01:14:53 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CC5A63CA48 for ; Tue, 15 Nov 2022 01:14:52 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouinu-0008Br-5Y; Mon, 14 Nov 2022 18:23:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouifz-0006Ib-T3 for emacs-orgmode@gnu.org; Mon, 14 Nov 2022 18:15:43 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouOhm-0002V7-9T for emacs-orgmode@gnu.org; Sun, 13 Nov 2022 20:56:12 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C2851240101 for ; Mon, 14 Nov 2022 02:55:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1668390959; bh=ZJCFhxgcblD4LLVMA7NxDfvUxFyNFeBbmmVU13cOQQs=; h=From:To:Cc:Subject:Date:From; b=MOrZdOpz8xXA4woJdmzhCzlxYra2op7Si+AzXEFU9siuJEJ+7xzq/O9kB6RiHdyis VC0d3GDcfDv0E95IF+4hirda9CiTpR/ZfZeCNpbTQ4croe0Hw3N/jkBDuo8d5JrKuN rSnv7r3L/17DluhMlVmDuwRFS+CRYGj7WUSwbJ+oqImlgAFvVHVzAyzcdhsPBzsscJ YAASLgATjjJI2wCSBkJpYxr+V+sbP/tIE+s04Hc89Ge35zXLawON/jHmNMkIk+dxQX E4ayn5A2KKwpWrAUZSKxQxiVWfdIczM3M6eV5QXf2ltqgIspWK9oiPSchMZ8MdZnKD 6R/Tqog6o27nA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4N9XTS4s89z6tmF; Mon, 14 Nov 2022 02:55:55 +0100 (CET) From: Ihor Radchenko To: Leo Butler Cc: Org Mode Mailing List Subject: Re: [PATCH] lisp/ob-octave.el, was [PATCH] rfc: using ert-deftest with side-effects In-Reply-To: <87pmdvamwf.fsf@t14.reltub.ca> References: <87mt92elyy.fsf@t14.reltub.ca> <87mt9128sz.fsf@localhost> <87zgd1b4rn.fsf_-_@t14.reltub.ca> <8735asbtfe.fsf@localhost> <87pmdvamwf.fsf@t14.reltub.ca> Date: Mon, 14 Nov 2022 01:56:36 +0000 Message-ID: <87bkpaguy3.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1668471292; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jMA9E4Ic17iWG6h1VVjn+EY3Tl4LhcNZUW4Tuh4mW8U=; b=f015cAvI2/lJC3/Yb6TmenknytWTnwrKExF6wWFsQf5wwk+rfeJ+lU8o9bYkrEcIFOyGOE vfIFDcoVYExXxWCRC1TlOHBmMWxqektfsLBBpimBuoMmdL6W1q69yQ+cvSmojrvhQ+41c6 AEuwjZWdbMblM1+fS/kzBOKBvskt/slMiUpTl6yv09ioHo+SHNUi67ojpgH6luIMEHEI8T 5+el0yNdnY6XYBYQcap7AgDtX+YAYuJlJx+rDrXtO64hh1iVIzirLF1/u5JwE/KXcPpkXg hsrnc9cvHA3Kwg+dKumxb97Dwpu+KgBN1UsMWytbkOmy7XwfPy2rLR6Ku4BkyA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1668471292; a=rsa-sha256; cv=none; b=te/4Fl2v3pkhcIH5rwXsBkHGI93n4UsnkuBlTevaOx0viKOJWnrA3xO6RmIWcoQa8tNTze 6flS7kPVzet3R5zDQSJxL3SGwKfEEnepTlsnJs92BZpRn83JU/Zx59loWN27JGQztwuFns guBDTzkpKTmjgQDVHgt2iFbGw3DkZ+TShFeY7EMP04MIGqWn6B0qj9KfAzrtimIvqNhxw8 jo0ZLaRQn1H/IXlnCBoykwOXzZnTFHTlSzH1Bt76SB8/tBnjw709QfS6EhqGootoy/XEZb cXknCWzsjTtS7OXewM6ET+cgDF5/i1//6RwZWrvKV79rwmrs6mjVmxD7QLGZWw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=MOrZdOpz; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.54 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=MOrZdOpz; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: CC5A63CA48 X-Spam-Score: -3.54 X-Migadu-Scanner: scn1.migadu.com X-TUID: MP0bRk14EFUh Leo Butler writes: > The amended patch is attached. Thanks for your helpful feedback. Thanks for the patch! It looks good, and the tests are passing. However, there is a side effect leaving testing/examples/octave-workspace file after running the tests. Can something be done about this? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at