From: Jack Kamm <jackkamm@gmail.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org, Liu Hui <liuhui1610@gmail.com>
Subject: Re: [PATCH] ob-python results handling for dicts, dataframes, arrays, and plots
Date: Fri, 18 Aug 2023 16:18:23 -0700 [thread overview]
Message-ID: <87bkf4aqio.fsf@gmail.com> (raw)
In-Reply-To: <87cyzlriem.fsf@localhost>
Ihor Radchenko <yantar92@posteo.net> writes:
> This is an ORG-NEWS entry for Version 9.4. Is it an intentional change?
Sorry, that was an accident. I've reverted it now:
https://github.com/jackkamm/org-mode/commit/f12a695d67bc5c06013d9fbe0af844c9739e347a
>> @@ -142,7 +144,9 @@ (defun org-babel-python-table-or-string (results)
>> "Convert RESULTS into an appropriate elisp value.
>> If the results look like a list or tuple, then convert them into an
>> Emacs-lisp table, otherwise return the results as a string."
>> - (let ((res (org-babel-script-escape results)))
>> + (let ((res (if (string-equal "{" (substring results 0 1))
>> + results ;don't covert dicts to elisp
>> + (org-babel-script-escape results))))
>
> You may also need to update the docstring for
> `org-babel-python-table-or-string' after this change.
That change got reverted in subsequent update when I changed dict to
return as table by default instead of string. So there's no need to
update the docstring anymore.
>> - body)))
>> - (`value (let ((tmp-file (org-babel-temp-file "python-")))
>> + (if graphics-file
>> + (format org-babel-python--output-graphics-wrapper
>> + body graphics-file)
>> + body))))
>> + (`value (let ((results-file (or graphics-file
>> + (org-babel-temp-file "python-"))))
>
> What about :results graphics file ?
Not entirely sure what you mean here.
When ":results graphics file", then graphics-file will be non-nil --
org-babel-execute:python passes graphics-file onto
org-babel-python-evaluate and then
org-babel-python-evaluate-external-process. In case of ":results
graphics file output", org-babel-python--output-graphics-wrapper is used
to save pyplot.gcf(). Or if ":results graphics file value", then
org-babel-python--def-format-value saves the result with
Figure.savefig().
next prev parent reply other threads:[~2023-08-18 23:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 23:46 [PATCH] ob-python results handling for dicts, dataframes, arrays, and plots Jack Kamm
2023-08-16 9:32 ` Ihor Radchenko
2023-08-17 4:04 ` Jack Kamm
2023-08-17 9:14 ` gerard.vermeulen
2023-08-17 12:10 ` Ihor Radchenko
2023-08-18 4:37 ` gerard.vermeulen
2023-08-18 6:01 ` gerard.vermeulen
2023-08-18 23:30 ` Jack Kamm
2023-08-19 8:50 ` Ihor Radchenko
2023-08-20 18:01 ` Jack Kamm
2023-08-20 18:21 ` Ihor Radchenko
2023-08-19 8:58 ` Ihor Radchenko
2023-08-20 18:13 ` Jack Kamm
2023-08-20 18:25 ` Ihor Radchenko
2023-08-22 23:37 ` Jack Kamm
2023-08-17 12:07 ` Ihor Radchenko
2023-08-18 22:49 ` Jack Kamm
2023-08-17 5:35 ` Liu Hui
2023-08-18 23:09 ` Jack Kamm
2023-08-20 12:13 ` Liu Hui
2023-08-20 18:31 ` Jack Kamm
2023-08-21 6:21 ` Liu Hui
2023-08-22 23:44 ` Jack Kamm
2023-08-17 11:57 ` Ihor Radchenko
2023-08-18 23:18 ` Jack Kamm [this message]
2023-08-19 8:54 ` Ihor Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkf4aqio.fsf@gmail.com \
--to=jackkamm@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=liuhui1610@gmail.com \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).