From: Fabio Natali <me@fabionatali.com>
To: Ihor Radchenko <yantar92@posteo.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: Issue with org-persist and Tramp
Date: Sat, 11 Nov 2023 09:48:33 +0000 [thread overview]
Message-ID: <87bkc0y61a.fsf@fabionatali.com> (raw)
In-Reply-To: <87edgxhmry.fsf@fabionatali.com>
On 2023-11-10, 11:26 +0000, Fabio Natali <me@fabionatali.com> wrote:
> On 2023-11-10, 11:13 +0000, Fabio Natali <me@fabionatali.com> wrote:
>> Brilliant. I think the second branch should read `(not (file-remote-p
>> file))', i.e. `file' instead of `associated'? It seems to work with that
>> micro amendment.
>
> Hm, I stand corrected, I retested it end-to-end and no, it doesn't seem
> to work. I'll post more details later. Cheers, Fabio.
Hi Ihor,
Sorry for the delay. My results below, after testing a couple of
different cases.
If the remote file had been saved before losing connection, then the
patch below will fix the problem. TRAMP will still hang for a while, as
it tries to reach the server but the buffer will be closed immediately
when using `tramp-cleanup-all-buffers' (or a variant thereof).
--- /tmp/test-0.el 2023-11-11 09:27:33.477117451 +0000
+++ /tmp/test-1.el 2023-11-11 09:27:14.217129703 +0000
@@ -5,7 +5,8 @@
(unless (stringp associated)
(setq associated (cadr associated)))
(let* ((rtn `(:file ,associated))
- (inode (and (fboundp 'file-attribute-inode-number)
+ (inode (and (not (file-remote-p associated))
+ (fboundp 'file-attribute-inode-number)
(file-attribute-inode-number
(file-attributes associated)))))
(when inode (plist-put rtn :inode inode))
@@ -25,6 +26,7 @@
(or (buffer-base-buffer associated)
associated)))
(setq inode (when (and file
+ (not (file-remote-p file))
(fboundp 'file-attribute-inode-number))
(file-attribute-inode-number
(file-attributes file))))
(Apologies, the patch is badly formatted and not meant for the
repository.) The gist is that I replaced an occurrence of `associated'
with `file' in your latest patch, Ihor. It seems to work, what do you
think?
However, if the remote file hadn't been saved, then TRAMP will still
hang indefinitely. Quitting will reveal the following backtrace:
Debugger entered--Lisp error: (quit "")
signal(quit (""))
tramp-error(nil quit "")
tramp-signal-hook-function(quit (""))
signal(quit (""))
tramp-maybe-open-connection((tramp-file-name "ssh" nil nil "192.168.1.100" nil "~/.#test.org" nil))
tramp-send-command((tramp-file-name "ssh" nil nil "192.168.1.100" nil "~/.#test.org" nil) "echo ~ 2>/dev/null; echo tramp_exit_status $?")
tramp-send-command-and-check((tramp-file-name "ssh" nil nil "192.168.1.100" nil "~/.#test.org" nil) "echo ~")
tramp-sh-handle-get-home-directory((tramp-file-name "ssh" nil nil "192.168.1.100" nil "~/.#test.org" nil) "")
tramp-sh-file-name-handler(tramp-get-home-directory (tramp-file-name "ssh" nil nil "192.168.1.100" nil "~/.#test.org" nil) "")
apply(tramp-sh-file-name-handler tramp-get-home-directory ((tramp-file-name "ssh" nil nil "192.168.1.100" nil "~/.#test.org" nil) ""))
tramp-file-name-handler(tramp-get-home-directory (tramp-file-name "ssh" nil nil "192.168.1.100" nil "~/.#test.org" nil) "")
tramp-get-home-directory((tramp-file-name "ssh" nil nil "192.168.1.100" nil "~/.#test.org" nil) "")
tramp-sh-handle-expand-file-name("/ssh:192.168.1.100:~/.#test.org" nil)
tramp-sh-file-name-handler(expand-file-name "/ssh:192.168.1.100:~/.#test.org" nil)
apply(tramp-sh-file-name-handler expand-file-name ("/ssh:192.168.1.100:~/.#test.org" nil))
tramp-file-name-handler(expand-file-name "/ssh:192.168.1.100:~/.#test.org" nil)
files--transform-file-name("/ssh:192.168.1.100:~/test.org" nil ".#" "")
make-lock-file-name("/ssh:192.168.1.100:~/test.org")
tramp-run-real-handler(make-lock-file-name ("/ssh:192.168.1.100:~/test.org"))
tramp-handle-make-lock-file-name("/ssh:192.168.1.100:~/test.org")
tramp-sh-file-name-handler(make-lock-file-name "/ssh:192.168.1.100:~/test.org")
apply(tramp-sh-file-name-handler make-lock-file-name "/ssh:192.168.1.100:~/test.org")
tramp-file-name-handler(make-lock-file-name "/ssh:192.168.1.100:~/test.org")
tramp-compat-make-lock-file-name("/ssh:192.168.1.100:~/test.org")
tramp-handle-unlock-file("/ssh:192.168.1.100:~/test.org")
tramp-sh-file-name-handler(unlock-file "/ssh:192.168.1.100:~/test.org")
apply(tramp-sh-file-name-handler unlock-file "/ssh:192.168.1.100:~/test.org")
tramp-file-name-handler(unlock-file "/ssh:192.168.1.100:~/test.org")
kill-buffer("test.org")
funcall-interactively(kill-buffer "test.org")
command-execute(kill-buffer)
This seems to be on the TRAMP side?
Cheers, Fabio.
next prev parent reply other threads:[~2023-11-11 9:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 13:58 Issue with org-persist and Tramp Fabio Natali
2023-11-07 21:08 ` Antonio Carlos Padoan Junior
2023-11-08 8:56 ` Fabio Natali
2023-11-08 9:25 ` Ihor Radchenko
2023-11-08 17:40 ` Fabio Natali
2023-11-08 18:01 ` Ihor Radchenko
2023-11-08 21:30 ` Fabio Natali
2023-11-09 12:17 ` Ihor Radchenko
2023-11-09 13:11 ` Fabio Natali
2023-11-10 9:26 ` Ihor Radchenko
2023-11-10 11:13 ` Fabio Natali
2023-11-10 11:26 ` Fabio Natali
2023-11-11 9:48 ` Fabio Natali [this message]
2023-11-11 11:06 ` Ihor Radchenko
2023-11-11 19:38 ` Fabio Natali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkc0y61a.fsf@fabionatali.com \
--to=me@fabionatali.com \
--cc=emacs-orgmode@gnu.org \
--cc=yantar92@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).