From: Matt Lundin <mdl@imapmail.org>
To: Bert Burgemeister <trebbu@googlemail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [Accepted] Making the output of %% functions linkable in agenda views
Date: Fri, 06 May 2011 07:47:43 -0400 [thread overview]
Message-ID: <87aaf0oxsw.fsf@fastmail.fm> (raw)
In-Reply-To: <80ei4c5kvp.fsf@ID-264851.user.dfncis.de> (Bert Burgemeister's message of "Fri, 06 May 2011 09:49:30 +0200")
Bert Burgemeister <trebbu@googlemail.com> writes:
> Just curious, is there anything I should have known that prevented the
> patch submitted in http://article.gmane.org/gmane.emacs.orgmode/39313,
Is it still in the bugtracker, or was it rejected? (I attempted to check
myself, but the patchwork site seems to be down right now.)
There has been a cascade of patches on the list recently (I plead guilty
to adding my fair share), and there aren't many people who are
authorized to push to the repo.
With your patch, what would happen if there were two or more links in
the headline?
* Two links
%%(format "%s" (concat "[[elisp:(info)]" "[Link to info]]"))
http://www.orgmode.org
This entry would show up in the agenda as:
org: [[elisp:(info)][Link to info]]
But AFAICT, hitting C-c C-o in the agenda-buffer (even on the elisp
link) would jump immediately to http://www.orgmode.org, bypassing the
opportunity to select the the %%(...) generated link.
Best,
Matt
>> From: Bert Burgemeister <trebbu@googlemail.com>
>> Subject: [O] [PATCH] Bugfix: org-agenda-open-link
>> Newsgroups: gmane.emacs.orgmode
>> To: emacs-orgmode@gnu.org
>> Date: Sun, 13 Mar 2011 16:18:44 +0100
>>
>>
>> * Org-agenda.el (org-agenda-open-link): C-c C-o didn't open links
>> inserted via the `%%( )' mechanism, affecting usability of
>> `%%(org-bbdb-anniversaries).
>>
>> TINYCHANGE
>> ---
>>
>>
>> The bug was apparently introduced in commit
>> ba1e90893d128d8004e4cb6763af692c5a6cd677.
>>
>> --
>> Bert
>>
>>
>>
>> lisp/org-agenda.el | 14 +++++++-------
>> 1 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
>> index 4b4dd68..123668c 100644
>> --- a/lisp/org-agenda.el
>> +++ b/lisp/org-agenda.el
>> @@ -6742,13 +6742,13 @@ at the text of the entry itself."
>> (+ (point-at-bol)
>> (or (org-get-at-bol 'prefix-length) 0)))))
>> (cond
>> - (buffer
>> - (with-current-buffer buffer
>> - (save-excursion
>> - (save-restriction
>> - (widen)
>> - (goto-char marker)
>> - (org-offer-links-in-entry arg prefix)))))
>> + ((and buffer
>> + (with-current-buffer buffer
>> + (save-excursion
>> + (save-restriction
>> + (widen)
>> + (goto-char marker)
>> + (org-offer-links-in-entry arg prefix))))))
>> ((or (org-in-regexp (concat "\\(" org-bracket-link-regexp "\\)"))
>> (save-excursion
>> (beginning-of-line 1)
>> --
>> 1.7.2.3
>
> from being noticed?
next prev parent reply other threads:[~2011-05-06 11:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 20:52 Making the output of %% functions linkable in agenda views Sebold, Charles
2011-05-03 16:59 ` charles.sebold
2011-05-03 17:28 ` Nick Dokos
2011-05-03 19:56 ` Matt Lundin
2011-05-03 20:04 ` Sebold, Charles
2011-05-03 20:09 ` Matt Lundin
2011-05-03 20:17 ` Sebold, Charles
2011-05-03 20:28 ` Nick Dokos
2011-05-03 20:47 ` Matt Lundin
2011-05-04 7:43 ` [Accepted] " Carsten Dominik
2011-05-06 7:49 ` Bert Burgemeister
2011-05-06 11:47 ` Matt Lundin [this message]
2011-05-07 15:20 ` Bert Burgemeister
2011-05-08 20:23 ` Carsten Dominik
2011-05-10 7:57 ` Bert Burgemeister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aaf0oxsw.fsf@fastmail.fm \
--to=mdl@imapmail.org \
--cc=emacs-orgmode@gnu.org \
--cc=trebbu@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).