From: Bastien <bzg@gnu.org>
To: Bill Wishon <bill@wishon.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] fix hook calling in org-export-remove-or-extract-drawers
Date: Tue, 01 May 2012 12:01:08 +0200 [thread overview]
Message-ID: <87aa1sw78b.fsf@gnu.org> (raw)
In-Reply-To: <CAP2uJAt9fJB-BfzH8d9kyJMERTtWYN-54t_b8F5+mYcp8Vd5WQ@mail.gmail.com> (Bill Wishon's message of "Mon, 30 Apr 2012 18:20:54 -0700")
Hi Bill,
Thanks for the patch. Please don't attach patches using
application/octet-stream, patchwork don't catch those -- see
http://orgmode.org/worg/org-contribute.html#sec-4-3
Bill Wishon <bill@wishon.org> writes:
> * lisp/org-exp.el (org-export-remove-or-extract-drawers): Changed
> funcall to run-hook-with-args-until-success to properly run the
> org-export-format-drawer-function hook.
>
> The problem was that funcall was being executed on the hook (list of
> functions) instead of running the hook with
> run-hook-with-args-until-success, which tries to run potentially a
> list of hooks until one returns non-nil.
I don't really understand why `run-hook-with-args-until-success' is
needed here. Or `org-export-format-drawer-function' returns a string,
or it returns nil, in case we fall back on `org-export-format-drawer'.
Maybe I miss something?
--
Bastien
next prev parent reply other threads:[~2012-05-01 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 1:20 [PATCH] fix hook calling in org-export-remove-or-extract-drawers Bill Wishon
2012-05-01 10:01 ` Bastien [this message]
2012-05-01 14:46 ` Bill Wishon
2012-05-01 17:58 ` Bastien
2012-05-01 18:02 ` Bill Wishon
2012-05-01 18:18 ` Nicolas Goaziou
2012-05-01 18:29 ` Bill Wishon
2012-05-02 12:35 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87aa1sw78b.fsf@gnu.org \
--to=bzg@gnu.org \
--cc=bill@wishon.org \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).