emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Ivan Vilata i Balaguer <ivan@selidor.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Allow relative times in clocktable tstart and tend options
Date: Wed, 28 Nov 2012 13:47:32 +0100	[thread overview]
Message-ID: <87a9u1ao7v.fsf@gmail.com> (raw)
In-Reply-To: <20121121230733.GA15586@edgar.selidor.net> (Ivan Vilata i. Balaguer's message of "Thu, 22 Nov 2012 00:07:33 +0100")

Hello,

Ivan Vilata i Balaguer <ivan@selidor.net> writes:

> * lisp/org-clock.el (org-clock-get-table-data): Pass tstart and tend
> time strings through `org-matcher-time` to allow relative times besides
> absolute ones, convert result to encoded time.
> * doc/org.texi (The clock table): Document acceptance of relative times
> in tstart and tend, link to syntax description.
>
> Inspired in the original relative times proposal by Ilya Shlyakhter,
> this is less invasive and it doesn't modify core functions, thus it
> avoids the original's infinite recursion when hitting normal dates in
> other locations.
>
> TINYCHANGE

Thank you for your patch.

Would you mind providing a (couple) of simple test case(s) (or better,
a complete ert test) for that situation?


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2012-11-28 12:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21 23:07 [PATCH] Allow relative times in clocktable tstart and tend options Ivan Vilata i Balaguer
2012-11-28 12:47 ` Nicolas Goaziou [this message]
2012-11-28 16:11   ` Ivan Vilata i Balaguer
2012-11-28 22:32     ` Ivan Vilata i Balaguer
2012-11-30 15:31       ` Nicolas Goaziou
2012-11-30 23:09         ` Ivan Vilata i Balaguer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9u1ao7v.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=ivan@selidor.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).