emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Rasmus <rasmus@gmx.us>
To: bzg@altern.org
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] replace function name in org-bbdb
Date: Sat, 30 Mar 2013 16:51:42 +0100	[thread overview]
Message-ID: <87a9pkvqb5.fsf@pank.eu> (raw)
In-Reply-To: <87boa1ymj3.fsf@bzg.ath.cx> (Bastien's message of "Sat, 30 Mar 2013 15:45:04 +0100")


Bastien,

>> org-bbdb-anniversary was not working on my system before using bbdb3
>> from package.el (probably from MELPA...).  This fixes this by renaming
>> a function which has been changed upstream.
>
> Looks good.  Is there any versioning we can check in order to know
> what function's name will the users use?

bbdb3 hasn't been released yet.  It's a moving target and I would
assume that people who use it are on the edge of the development. . .
The function(s) in question were renamed four months ago.

In any case this function will check that one has a sufficiently new
version of of bbdb (based on the change log I linked to in the commit
message).  Should I make a local version of the bbdb field lookup
function and let the value be determined by the test below?  I
unfortunately don't know what the version was called around 2012/12/25
so I test using the date, which may or may not be too fragile.

#+BEGIN_SRC emacs-lisp

(when (fboundp 'bbdb-version)
  (string-match "\\([0-9]\\{4\\}/[0-9]\\{2\\}/[0-9]\\{2\\}\\)" (bbdb-version))
  (version<=
   (replace-regexp-in-string "/" "."
			     (match-string 1 (bbdb-version)))
   "2012.12.25"))
#+END_SRC

Thanks,
Rasmus

-- 
May the Force be with you

next prev parent reply	other threads:[~2013-03-30 15:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-30 13:17 [PATCH] replace function name in org-bbdb Rasmus
2013-03-30 14:45 ` Bastien
2013-03-30 15:51   ` Rasmus [this message]
2013-04-03 11:55     ` Bastien
2013-04-03 14:38       ` Rasmus
2013-04-03 14:46         ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9pkvqb5.fsf@pank.eu \
    --to=rasmus@gmx.us \
    --cc=bzg@altern.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).