From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH] Fix several byte-compile warnings in org-contrib files
Date: Mon, 01 Apr 2013 16:27:32 +0200
Message-ID: <87a9pitjfv.fsf@gmail.com>
References: <1364783083-3175-1-git-send-email-aaronecay@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:38506)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UMfi0-0008GG-Ga
	for emacs-orgmode@gnu.org; Mon, 01 Apr 2013 10:27:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UMfhx-0006R4-Sn
	for emacs-orgmode@gnu.org; Mon, 01 Apr 2013 10:27:40 -0400
Received: from mail-wg0-f46.google.com ([74.125.82.46]:43098)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1UMfhx-0006QE-N9
	for emacs-orgmode@gnu.org; Mon, 01 Apr 2013 10:27:37 -0400
Received: by mail-wg0-f46.google.com with SMTP id l18so2089350wgh.1
	for <emacs-orgmode@gnu.org>; Mon, 01 Apr 2013 07:27:36 -0700 (PDT)
In-Reply-To: <1364783083-3175-1-git-send-email-aaronecay@gmail.com> (Aaron
	Ecay's message of "Sun, 31 Mar 2013 22:24:43 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Aaron Ecay <aaronecay@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Thanks for your patch. Here are a few comments.

Aaron Ecay <aaronecay@gmail.com> writes:

> +(require 'cl-lib)

This is not an option since Org has to support Emacsen older than 24.3.

> -      (add (remove-if (lambda (author) (string-match "others" author))
> -		      (remove-duplicates (apply #'append (col :authors))
> +      (add (cl-remove-if (lambda (author) (string-match "others" author))
> +		      (cl-remove-duplicates (apply #'append (col :authors))
>  					 :test #'string=)))

Here, we can use `org-remove-if' and `org-uniquify'.


Regards,

-- 
Nicolas Goaziou