From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: org-cycle-hook from org-mode hook Date: Mon, 06 Jan 2014 17:47:22 +0100 Message-ID: <87a9f96orp.fsf@bzg.ath.cx> References: <87wqidw6kl.fsf@iro.umontreal.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34052) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0DKv-0002Um-D7 for emacs-orgmode@gnu.org; Mon, 06 Jan 2014 11:47:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0DKp-0006Xh-Qf for emacs-orgmode@gnu.org; Mon, 06 Jan 2014 11:47:33 -0500 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:60645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0DKp-0006XS-Jj for emacs-orgmode@gnu.org; Mon, 06 Jan 2014 11:47:27 -0500 Received: by mail-wi0-f179.google.com with SMTP id z2so3049429wiv.6 for ; Mon, 06 Jan 2014 08:47:26 -0800 (PST) In-Reply-To: <87wqidw6kl.fsf@iro.umontreal.ca> (=?iso-8859-1?Q?=22Fran=E7o?= =?iso-8859-1?Q?is?= Pinard"'s message of "Mon, 06 Jan 2014 09:03:38 -0500") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: =?iso-8859-1?Q?Fran=E7ois?= Pinard Cc: emacs-orgmode@gnu.org Hi François, François Pinard writes: > I noticed a recent change in Org mode behaviour, which I guess is > related to a "git pull" of the org-mode project. This is so minor that > it is hardly a problem for me, I only report it in case it would hint at > some unwanted change that would have more consequences for others. Thanks for reporting this. The commit introducing the change must be this one: http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=44acd000 > Opening an Org file in Emacs executes the hooks on org-mode-hooks. > Previously, it also executed the hooks on org-cycle-hook, while now, I > have the impression it does not anymore. The solution is easy for me, I > merely run my own Org cycle hook function from my main Org mode hook. The function `org-set-startup-visibility' is always called when you find an Org file interactively. Previously, it used `org-cycle' internally to set the visibility state. Now it uses `org-content` and `org-overview' instead, so that C-u C-u TAB always work. I think it makes sense to call org-cycle-hooks *only* when cycling manually, so the current behavior makes sense IMO. Let me know if you (or others) think otherwise. -- Bastien