emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@gnu.org>
To: Nicolas Goaziou <n.goaziou@gmail.com>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: [RFC] Properly handle keyword + COMMENT keyword
Date: Fri, 11 Apr 2014 10:59:11 +0200	[thread overview]
Message-ID: <87a9bs57cg.fsf@bzg.ath.cx> (raw)
In-Reply-To: <87sipkkiro.fsf@gmail.com> (Nicolas Goaziou's message of "Thu, 10 Apr 2014 22:54:19 +0200")

Hi Nicolas,

Nicolas Goaziou <n.goaziou@gmail.com> writes:

> Nicolas Goaziou <n.goaziou@gmail.com> writes:
>
>> Thus, this patch
>>
>>  - properly fontifies headlines with both a regular keyword and
>>    a COMMENT keyword,
>>
>>  - fixes `org-toggle-comment' and `org-todo' to handle both COMMENT
>>    keyword and another one
>>
>>  - adds some consistency to functions implementing their own COMMENT
>>    matching (e.g., with or without case-sensitivity).
>
> Applied.

Thanks -- this is a welcome improvement.

Speaking of consistency, I noticed this minor glitch:

* NEXT COMMENT A headline [0/2]

- [ ] A
- [ ] B

* NEXT [#A] [1/2] COMMENT Another headline

- [X] A
- [ ] B

See that the second COMMENT is not fontified and I think
it will not be processed correctly.

Now that COMMENT will not be always the first word of a
headline, we should mention that TODO keywords and priority
cookies are allowed before a COMMENT keyword, while stats
cookies are not.  (Or allow stats cookies for simplicity's
sake.)

What do you think?

-- 
 Bastien

next prev parent reply	other threads:[~2014-04-11 13:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-24 21:38 [RFC] Properly handle keyword + COMMENT keyword Nicolas Goaziou
2014-03-24 21:48 ` Samuel Wales
2014-03-24 22:04   ` Nicolas Goaziou
2014-04-10 20:54 ` Nicolas Goaziou
2014-04-11  8:59   ` Bastien [this message]
2014-04-11 19:42     ` Nicolas Goaziou
2014-04-11 20:13       ` Bastien
2014-04-12  9:03         ` Nicolas Goaziou
2014-04-16 14:39           ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a9bs57cg.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=n.goaziou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).