emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] Fix id generation in ox-rss.el
@ 2014-07-23 19:23 Matt Lundin
  2014-07-27 12:05 ` Bastien
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Lundin @ 2014-07-23 19:23 UTC (permalink / raw)
  To: Org Mode

[-- Attachment #1: Type: text/plain, Size: 322 bytes --]

The attached patch fixes a bug in ox-rss.el that causes org-publish to
generate IDs in whatever org buffer emacs happens to be currently
visiting. I was puzzled why my org files were suddenly filled with
hundreds of ID entries. I discovered it happened when I called org
publish while visiting those files.

Thanks,
Matt


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-ID-generation-in-org-rss-publish-to-rss.patch --]
[-- Type: text/x-diff, Size: 1239 bytes --]

From b482d2ebd53a60a91355433f49350b450869451e Mon Sep 17 00:00:00 2001
From: Matt Lundin <mdl@imapmail.org>
Date: Wed, 23 Jul 2014 14:18:06 -0500
Subject: [PATCH] Fix ID generation in org-rss-publish-to-rss

* contrib/lisp/ox-rss.el: (org-rss-publish-to-rss) Fix a bug that
  causes ID properties to be generated in org buffer emacs is
  currently visiting rather than the file containing the feed. This
  bug can cause hundreds of ID entries to be added to an org file
  unrelated to the publishing project.
---
 contrib/lisp/ox-rss.el | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/contrib/lisp/ox-rss.el b/contrib/lisp/ox-rss.el
index c69a37b..5cae288 100644
--- a/contrib/lisp/ox-rss.el
+++ b/contrib/lisp/ox-rss.el
@@ -204,11 +204,10 @@ publishing directory.
 Return output file name."
   (let ((bf (get-file-buffer filename)))
     (if bf
-	(progn
-	  (org-icalendar-create-uid filename 'warn-user)
 	  (with-current-buffer bf
+	    (org-icalendar-create-uid filename 'warn-user)
 	    (org-rss-add-pubdate-property)
-	    (write-file filename)))
+	    (write-file filename))
       (find-file filename)
       (org-icalendar-create-uid filename 'warn-user)
       (org-rss-add-pubdate-property)
-- 
2.0.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix id generation in ox-rss.el
  2014-07-23 19:23 [PATCH] Fix id generation in ox-rss.el Matt Lundin
@ 2014-07-27 12:05 ` Bastien
  0 siblings, 0 replies; 2+ messages in thread
From: Bastien @ 2014-07-27 12:05 UTC (permalink / raw)
  To: Matt Lundin; +Cc: Org Mode

Hi Matt,

Matt Lundin <mdl@imapmail.org> writes:

> The attached patch fixes a bug in ox-rss.el that causes org-publish to
> generate IDs in whatever org buffer emacs happens to be currently
> visiting. I was puzzled why my org files were suddenly filled with
> hundreds of ID entries. I discovered it happened when I called org
> publish while visiting those files.

Applied, thanks for catching this ugly bug.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-28 17:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-23 19:23 [PATCH] Fix id generation in ox-rss.el Matt Lundin
2014-07-27 12:05 ` Bastien

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).