From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: Could org-mode use `completing-read-function' instead of `org-icompleting-read'? Date: Thu, 16 Apr 2015 17:47:07 +0200 Message-ID: <87a8y8t6ro.fsf@gmx.us> References: <87egnk17wg.fsf@gmx.us> <87egnkt7yv.fsf@gmx.us> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yim0l-0007JT-I7 for emacs-orgmode@gnu.org; Thu, 16 Apr 2015 11:47:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yim0g-0007P4-0n for emacs-orgmode@gnu.org; Thu, 16 Apr 2015 11:47:27 -0400 Received: from plane.gmane.org ([80.91.229.3]:37425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yim0f-0007Ou-PX for emacs-orgmode@gnu.org; Thu, 16 Apr 2015 11:47:21 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Yim0Z-0007h9-SD for emacs-orgmode@gnu.org; Thu, 16 Apr 2015 17:47:16 +0200 Received: from 46.166.188.202 ([46.166.188.202]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 16 Apr 2015 17:47:15 +0200 Received: from rasmus by 46.166.188.202 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 16 Apr 2015 17:47:15 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Hi, Oleh Krehel writes: >> I don't know how to use helm of ivy. But I think the attached patch is >> better. Would that work with helm and ivy? > > I could live with it, but basically `org-completion-use-ido` says "I > don't care if you've temporarily disabled `ido-mode' or not, I'll use > ido anyway". This isn't a good approach, especially considering that > `ido-mode' is already a convenient minor mode. > Maybe `org-completion-use-ido' should be completely removed, and ido completion > should be used automatically when `ido-mode' is on. Ideally it should just depend on the whatever default functions set. E.g. for me read-file-name-function => ido-read-file-name on my system. Perhaps org-completion-use-ido can be made obsolete and just read ido-everywhere. Oleh Krehel writes: >>> I don't know how to use helm of ivy. But I think the attached patch is >>> better. Would that work with helm and ivy? > > Yes, both work fine. > >> I could live with it, but basically `org-completion-use-ido` says "I >> don't care if you've temporarily disabled `ido-mode' or not, I'll use >> ido anyway". This isn't a good approach, especially considering that >> `ido-mode' is already a convenient minor mode. >> Maybe `org-completion-use-ido' should be completely removed, and ido >> completion >> should be used automatically when `ido-mode' is on. > > Oops, just noticed that `ido-mode' is actually in the condition. > All is fine then. > > Except that iswitchb is obsolete. Should we remove it? The target release of Org 8.3 is something like Emacs23 (or maybe 24.3?). In either case we can't obsolete it until 8.4 since iswitchb is obsolete from 24.4... —Rasmus -- Send from my Emacs