From: Rasmus <rasmus@gmx.us>
To: emacs-orgmode@gnu.org
Subject: Re: Could org-mode use `completing-read-function' instead of `org-icompleting-read'?
Date: Thu, 16 Apr 2015 17:47:07 +0200 [thread overview]
Message-ID: <87a8y8t6ro.fsf@gmx.us> (raw)
In-Reply-To: CAA01p3r=347vt8-ZZ26VSYGCFE=K4A9zfH7R3yLEPjoGu8WVVg@mail.gmail.com
Hi,
Oleh Krehel <ohwoeowho@gmail.com> writes:
>> I don't know how to use helm of ivy. But I think the attached patch is
>> better. Would that work with helm and ivy?
>
> I could live with it, but basically `org-completion-use-ido` says "I
> don't care if you've temporarily disabled `ido-mode' or not, I'll use
> ido anyway". This isn't a good approach, especially considering that
> `ido-mode' is already a convenient minor mode.
> Maybe `org-completion-use-ido' should be completely removed, and ido completion
> should be used automatically when `ido-mode' is on.
Ideally it should just depend on the whatever default functions set.
E.g. for me read-file-name-function => ido-read-file-name on my system.
Perhaps org-completion-use-ido can be made obsolete and just read
ido-everywhere.
Oleh Krehel <ohwoeowho@gmail.com> writes:
>>> I don't know how to use helm of ivy. But I think the attached patch is
>>> better. Would that work with helm and ivy?
>
> Yes, both work fine.
>
>> I could live with it, but basically `org-completion-use-ido` says "I
>> don't care if you've temporarily disabled `ido-mode' or not, I'll use
>> ido anyway". This isn't a good approach, especially considering that
>> `ido-mode' is already a convenient minor mode.
>> Maybe `org-completion-use-ido' should be completely removed, and ido
>> completion
>> should be used automatically when `ido-mode' is on.
>
> Oops, just noticed that `ido-mode' is actually in the condition.
> All is fine then.
>
> Except that iswitchb is obsolete. Should we remove it?
The target release of Org 8.3 is something like Emacs23 (or maybe 24.3?).
In either case we can't obsolete it until 8.4 since iswitchb is obsolete
from 24.4...
—Rasmus
--
Send from my Emacs
prev parent reply other threads:[~2015-04-16 15:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 13:36 Could org-mode use `completing-read-function' instead of `org-icompleting-read'? Oleh Krehel
2015-04-16 14:10 ` Rasmus
2015-04-16 14:31 ` Oleh Krehel
2015-04-16 15:21 ` Rasmus
2015-04-16 15:30 ` Oleh Krehel
2015-04-16 15:35 ` Oleh Krehel
2015-04-16 17:45 ` Marcin Borkowski
2015-04-16 18:02 ` Oleh Krehel
2015-04-16 18:05 ` Rasmus
2015-04-16 22:25 ` Marcin Borkowski
2015-04-16 15:47 ` Rasmus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8y8t6ro.fsf@gmx.us \
--to=rasmus@gmx.us \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).