From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Malakhovski <oxij@oxij.org>
Subject: Re: [PATCH 9/9] ob-calc: don't leave garbage on the stack
Date: Wed, 04 Nov 2015 11:53:54 +0000
Message-ID: <87a8qum14d.fsf@yin.lan>
References: <1446581747-1960-1-git-send-email-oxij@oxij.org>
	<1446581747-1960-10-git-send-email-oxij@oxij.org>
	<87fv0mvw5k.fsf@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41027)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <oxij@oxij.org>) id 1Ztwdc-0003Qg-MV
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:54:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <oxij@oxij.org>) id 1ZtwdZ-0002Xg-E6
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:54:00 -0500
Received: from tricoro.koumakan.jp ([195.154.188.176]:60985)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <oxij@oxij.org>) id 1ZtwdZ-0002Xc-8V
	for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:53:57 -0500
In-Reply-To: <87fv0mvw5k.fsf@gmail.com>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Aaron Ecay <aaronecay@gmail.com>, emacs-orgmode@gnu.org

Aaron Ecay <aaronecay@gmail.com> writes:

> Are you missing a close paren at the end of the above line?

It evaluates and works ok, so I think it's ok.

> Also, shouldn=E2=80=99t calc-eval take a string as an argument, not a lisp
> form? (I=E2=80=99m asking based on the docstring, I don=E2=80=99t know th=
e calc API at
> all).

1) It was like this before.
2) It works.
3) calc-eval calls calc-do-calc-eval on this argument and the code
   there does a dispatch on expression, so I think it's safe to assume
   it's not actually a string (calc is a mess, yep).