* [PATCH] org.el: Fix bug from switch to lexical binding
@ 2016-04-08 12:47 Michael Strey
2016-04-08 21:13 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Michael Strey @ 2016-04-08 12:47 UTC (permalink / raw)
To: emacs-orgmode
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
Please check carefully before applying! I do not understand what I have
done here but it worked for me without side effects.
--
Michael Strey
_
mailto:mstrey@strey.biz
http://www.strey.biz * https://twitter.com/michaelstrey
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch --]
[-- Type: text/x-diff, Size: 1331 bytes --]
From b76d6ef5975e1ba0b5ad4317246e1084d43ff446 Mon Sep 17 00:00:00 2001
From: Michael Strey <mstrey@strey.biz>
Date: Fri, 8 Apr 2016 14:03:30 +0200
Subject: [PATCH] org.el: Fix bug from switch to lexical binding
* lisp/org.el (org-check-dates-range): Fix a bug introduces with the
switch to lexical binding in commit
1f49e9fdfd8b527377b5592bd65ad3be6abb9e6a.
This change fixed the following bug: C-c \ D leads to error message "Symbol's value as variable is void: start-date".
TINYCHANGE
---
lisp/org.el | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index 4f60c7f..b6d1c2d 100644
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -17489,12 +17489,12 @@ both scheduled and deadline timestamps."
(let ((case-fold-search nil)
(regexp (org-re-timestamp org-ts-type))
(callback
- `(lambda ()
+ (lambda ()
(let ((match (match-string 1)))
(and
- ,(if (memq org-ts-type '(active inactive all))
- '(eq (org-element-type (org-element-context)) 'timestamp)
- '(org-at-planning-p))
+ (if (memq org-ts-type '(active inactive all))
+ (eq (org-element-type (org-element-context)) 'timestamp)
+ (org-at-planning-p))
(not (time-less-p
(org-time-string-to-time match)
(org-time-string-to-time start-date)))
--
2.7.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] org.el: Fix bug from switch to lexical binding
2016-04-08 12:47 [PATCH] org.el: Fix bug from switch to lexical binding Michael Strey
@ 2016-04-08 21:13 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2016-04-08 21:13 UTC (permalink / raw)
To: Michael Strey; +Cc: emacs-orgmode
Hello,
Michael Strey <mstrey@strey.biz> writes:
> Please check carefully before applying! I do not understand what I have
> done here but it worked for me without side effects.
Applied, with a minor change. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-08 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-08 12:47 [PATCH] org.el: Fix bug from switch to lexical binding Michael Strey
2016-04-08 21:13 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).