emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Marcus Zibrowius <marcus.zibrowius@hhu.de>
Cc: Org Mode List <emacs-orgmode@gnu.org>
Subject: Re: Basic visibility cycling bug in 8.3.6
Date: Mon, 17 Oct 2016 08:42:43 +0200	[thread overview]
Message-ID: <87a8e3pjbw.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <1476597091.2755.18.camel@XPS12> (Marcus Zibrowius's message of "Sun, 16 Oct 2016 07:51:31 +0200")

Hello,

Marcus Zibrowius <marcus.zibrowius@hhu.de> writes:

Cc'ing to the list for further discussion.

> Excellent!   Thanks a lot for helping so quickly.  I still maintain that
> the behaviour is different for me in org-mode 7.9.3, but I understand
> now that it's a (new?) feature rather than a bug.

I misread your version string. The behaviour you describe doesn't happen
in Org 7.9.3f, but was introduced in
2efbd0f138180fe14773d5485ad3c59332d6ddb3, i.e., between Org 7.9.3f and
and Org 7.9.4. I can indeed observe the same with the latter.

However this change never made it into the following release, i.e., Org
8.0. You're observing a very short-lived feature.

> Let me reiterate what I think is different , now that I understand
> better what is happening:  in org-mode 8.3.6, if I start with 
>
> * a
> ** b
> ** c
> ** d
> ** e
> ** f
> ** g
> ** h
>
> with point at e, then if I collapse with Shift+TAB and reexpand with
> TAB, I get only:
>
> * a...
> ** e
> ...
>
> with point at the beginning of the line **e, and I can reexpand the
> whole tree with C-c C-r.   So the line in which point was is somehow
> remembered.  In contrast, Shift+TAB followed by TAB in org-mode 7.9.3f
> (details below) brings back the whole tree directly, but forgets where
> point was:  point ends up just right of a.

I think it is important to preserve point when cycling view. It would be
surprising if a function modifying visibility also moved it. Besides,
this is useful when one wants to have a glimpse to the overview (S-TAB)
and go back to the editing location (another S-TAB) immediatly after.

I have no strong opinion on what should be displayed when pressing TAB
in this case, tho. It seems the implentation of `org-cycle' sort of
decided for us, i.e., it wasn't meant to handle this situation.

Regards,

-- 
Nicolas Goaziou                                                0x80A93738

      parent reply	other threads:[~2016-10-17  6:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-15 15:22 Basic visibility cycling bug in 8.3.6 Marcus Zibrowius
2016-10-15 20:25 ` Nicolas Goaziou
     [not found]   ` <1476597091.2755.18.camel@XPS12>
2016-10-17  6:42     ` Nicolas Goaziou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8e3pjbw.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=emacs-orgmode@gnu.org \
    --cc=marcus.zibrowius@hhu.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).