From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] Fix ox-md remote image links export
Date: Sun, 06 Aug 2017 09:15:10 +0200
Message-ID: <87a83df9q9.fsf@nicolasgoaziou.fr>
References: <CACe_Yv-rfFmeON1Qo+PsmheJojymW0=czmTscKJOFW=yGBrr1w@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37977)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1deFmO-0000ua-Ds
	for emacs-orgmode@gnu.org; Sun, 06 Aug 2017 03:15:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1deFmL-0001rj-Au
	for emacs-orgmode@gnu.org; Sun, 06 Aug 2017 03:15:16 -0400
Received: from relay2-d.mail.gandi.net ([217.70.183.194]:58532)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1deFmL-0001pN-4T
	for emacs-orgmode@gnu.org; Sun, 06 Aug 2017 03:15:13 -0400
In-Reply-To: <CACe_Yv-rfFmeON1Qo+PsmheJojymW0=czmTscKJOFW=yGBrr1w@mail.gmail.com>
	(Jay Kamat's message of "Sat, 5 Aug 2017 19:43:04 -0700")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Jay Kamat <jaygkamat@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Jay Kamat <jaygkamat@gmail.com> writes:

> I discovered a bug in the ox-md exporter and have created a patch to fix it:
>
> Previously, this image link:
> [[https://git-scm.com/images/logo@2x.png]]
>
> would export to:
> ![img](//git-scm.com/images/logo@2x.png)
>
> which is an invalid markdown image, and won't display properly in
> browsers and other places.
>
> A workaround (which I have been using extremely heavily), is:
> [[file:https://git-scm.com/images/logo@2x.png]]
>
> which exports to
> ![img](https://git-scm.com/images/logo@2x.png)
>
> Which is the proper (unbroken) image link.
>
> I have attached a patch which fixes the first example, so it exports
> the same link as the workaround (and is no longer broken).

Thank you for the report and the patch. I have committed a slightly
different change. Does it solve your issue?

> My papers are currently being processed, but I thought I would post
> this patch early to get feedback, since ideally I would like this bug
> to be fixed as soon as possible :). Hopefully they'll be done before
> the review is completed.

Great! Let me know when the process is done.

Regards,

-- 
Nicolas Goaziou