* [PATCH] Do not save target buffer after archiving subtree
@ 2017-11-26 4:00 Matt Lundin
2017-11-26 9:52 ` Nicolas Goaziou
0 siblings, 1 reply; 2+ messages in thread
From: Matt Lundin @ 2017-11-26 4:00 UTC (permalink / raw)
To: Org Mode
[-- Attachment #1: Type: text/plain, Size: 536 bytes --]
The attached patch removes the call to save-buffer in
org-archive-subtree. This significantly reduces the time necessary to
archive a subtree, especially when archiving many subtrees in a region.
Without this patch, Org Mode will save the archive buffer after each
subtree is archived. If one were archiving a region of 50 trees, this
would result in 50 writes to disk in quick succession. This patch makes
the behavior of org-archive-subtree match that of org-refile, which does
not save the target buffer after a refile.
Best,
Matt
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Do-not-save-target-buffer-after-archiving-subtree.patch --]
[-- Type: text/x-diff, Size: 1273 bytes --]
From 5c10b578461879d2770a85ae69c8182942074ee7 Mon Sep 17 00:00:00 2001
From: Matt Lundin <mclundin@gmail.com>
Date: Sat, 25 Nov 2017 09:26:15 -0600
Subject: [PATCH] Do not save target buffer after archiving subtree
* lisp/org-archive.el: (org-archive-subtree) Do not save buffer after
each archive. Saving the archive buffer after archiving each subtree
results in substantial slowdown and many writes to disk when
archiving an active region. This brings the behavior of
org-archive-subtree into line with org-refile, which does not save
the target buffer after refiling.
---
lisp/org-archive.el | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/lisp/org-archive.el b/lisp/org-archive.el
index b2e2178dc..37c5d6f62 100644
--- a/lisp/org-archive.el
+++ b/lisp/org-archive.el
@@ -381,10 +381,7 @@ direct children of this heading."
(point)
(concat "ARCHIVE_" (upcase (symbol-name item)))
value))))
- (widen)
- ;; Save and kill the buffer, if it is not the same
- ;; buffer.
- (unless (eq this-buffer buffer) (save-buffer)))))
+ (widen))))
;; Here we are back in the original buffer. Everything seems
;; to have worked. So now run hooks, cut the tree and finish
;; up.
--
2.15.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Do not save target buffer after archiving subtree
2017-11-26 4:00 [PATCH] Do not save target buffer after archiving subtree Matt Lundin
@ 2017-11-26 9:52 ` Nicolas Goaziou
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2017-11-26 9:52 UTC (permalink / raw)
To: Org Mode
Hello,
Matt Lundin <mdl@imapmail.org> writes:
> The attached patch removes the call to save-buffer in
> org-archive-subtree. This significantly reduces the time necessary to
> archive a subtree, especially when archiving many subtrees in a region.
> Without this patch, Org Mode will save the archive buffer after each
> subtree is archived. If one were archiving a region of 50 trees, this
> would result in 50 writes to disk in quick succession. This patch makes
> the behavior of org-archive-subtree match that of org-refile, which does
> not save the target buffer after a refile.
Good catch. Applied. Thank you.
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-11-26 9:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-26 4:00 [PATCH] Do not save target buffer after archiving subtree Matt Lundin
2017-11-26 9:52 ` Nicolas Goaziou
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).