emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] org-agenda-list: call recenter only when buffer is visible
@ 2018-04-03 22:24 Pierre Téchoueyres
  2018-04-05 14:46 ` Nicolas Goaziou
  0 siblings, 1 reply; 2+ messages in thread
From: Pierre Téchoueyres @ 2018-04-03 22:24 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 629 bytes --]

Hello org's developers,

I'm trying to correct the package `org-alert'
(https://github.com/spegoraro/org-alert) in order to not interfer with
the org-agenda buffer.

I've tried to call `org-agenda-list' inside a temp buffer. This could
work but the call to `recenter' throw an error which defeat the purpose
of temp buffer.

So could it be possible to apply the attached patch inside the
maintenance branch ? I see the unconditionnal call to `recenter' more as
an bug than a feature.

If it's not possible / desirable. Is there any function to achieve the
following goal : list the next scheduled / dead-lined events of today ?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org-agenda-patch --]
[-- Type: text/x-patch, Size: 1539 bytes --]

From 664b3d560f6d4caa00500add879923945453b7a7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pierre=20T=C3=A9choueyres?= <pierre.techoueyres@free.fr>
Date: Wed, 28 Mar 2018 01:35:22 +0200
Subject: [PATCH] org-agenda.el Call `recenter' only if buffer has a window.

* lisp/org-agenda.el (org-agenda-list): Condition the call to
  `recenter` only when the buffer has a window associated.

This permit to call `org-agenda-list` in a `with-temp-buffer` like
below:

(with-temp-buffer
  (let ((org-agenda-sticky nil)
        (org-agenda-buffer-tmp-name (buffer-name)))
    (org-agenda-list 1)
    (buffer-string))
---
 lisp/org-agenda.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el
index 649f5e2aa..cfe844536 100644
--- a/lisp/org-agenda.el
+++ b/lisp/org-agenda.el
@@ -4274,14 +4274,15 @@ items if they have an hour specification like [h]h:mm."
 	  (insert tbl)))
       (goto-char (point-min))
       (or org-agenda-multi (org-agenda-fit-window-to-buffer))
-      (unless (and (pos-visible-in-window-p (point-min))
+      (when (get-buffer-window)
+	(unless (and (pos-visible-in-window-p (point-min))
 		   (pos-visible-in-window-p (point-max)))
 	(goto-char (1- (point-max)))
 	(recenter -1)
 	(if (not (pos-visible-in-window-p (or start-pos 1)))
 	    (progn
 	      (goto-char (or start-pos 1))
-	      (recenter 1))))
+	      (recenter 1)))))
       (goto-char (or start-pos 1))
       (add-text-properties (point-min) (point-max)
 			   `(org-agenda-type agenda
-- 
2.14.3


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] org-agenda-list: call recenter only when buffer is visible
  2018-04-03 22:24 [PATCH] org-agenda-list: call recenter only when buffer is visible Pierre Téchoueyres
@ 2018-04-05 14:46 ` Nicolas Goaziou
  0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Goaziou @ 2018-04-05 14:46 UTC (permalink / raw)
  To: Pierre Téchoueyres; +Cc: emacs-orgmode

Hello,

Pierre Téchoueyres <pierre.techoueyres@free.fr> writes:

> Hello org's developers,
>
> I'm trying to correct the package `org-alert'
> (https://github.com/spegoraro/org-alert) in order to not interfer with
> the org-agenda buffer.
>
> I've tried to call `org-agenda-list' inside a temp buffer. This could
> work but the call to `recenter' throw an error which defeat the purpose
> of temp buffer.
>
> So could it be possible to apply the attached patch inside the
> maintenance branch ? I see the unconditionnal call to `recenter' more as
> an bug than a feature.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-08  8:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-03 22:24 [PATCH] org-agenda-list: call recenter only when buffer is visible Pierre Téchoueyres
2018-04-05 14:46 ` Nicolas Goaziou

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).