From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Subject: Re: Support showing stars as pretty bullets Date: Sat, 14 Apr 2018 15:10:35 +0200 Message-ID: <87a7u63pdg.fsf@gmx.us> References: <874lkutzg8.fsf@gmail.com> <878ta51m3w.fsf@nicolasgoaziou.fr> <87sh8di0je.fsf@gmail.com> <87woxoztd5.fsf@nicolasgoaziou.fr> <87k1tofjlo.fsf@gmail.com> <87vad8vxld.fsf@nicolasgoaziou.fr> <87370ak4a0.fsf@gmail.com> <87r2nt4y2f.fsf@nicolasgoaziou.fr> <87po37nja7.fsf@gmail.com> <871sfiozse.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f7Kx5-000824-JN for emacs-orgmode@gnu.org; Sat, 14 Apr 2018 09:10:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f7Kx1-0008UR-HN for emacs-orgmode@gnu.org; Sat, 14 Apr 2018 09:10:47 -0400 Received: from [195.159.176.226] (port=46095 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f7Kx1-0008T8-A8 for emacs-orgmode@gnu.org; Sat, 14 Apr 2018 09:10:43 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1f7Kus-0007IT-Hv for emacs-orgmode@gnu.org; Sat, 14 Apr 2018 15:08:30 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Nicolas Goaziou writes: > Hello, > > Alex Branham writes: > >> But then users of global-prettify-symbols-mode don't see the pretty >> symbols in org buffers without knowing about and activating >> org-pretty-mode. Anyway, the attached patch moves it to org-pretty.el. > > [...] > >> I've left it as a defvar since there's no way for us to know about what >> people want prettified where. Hopefully the default >> prettify-symbols-compose-p function does an OK job, but people will have >> to modify that if they customize org-pretty-alist anyway. > > I think there's a misunderstanding. To me, `prettify-symbols-mode' is > the plumbing. Org Pretty users should not have to care about it. > Likewise, when you use Org Bullets, you don't really care about how it > is done internally. > > As such, we know what people want prettified if we provide the > appropriate defcustom. > > BTW, the plumbing should be `compose-region', not > `prettify-symbols-mode'. IMO ‘prettify-symbols-mode’ is not pluming. It’s an Emacs-wide equivalent of "org-pretty-entities" (or at least the result when that variable is non-nil). IMO, the goal would be to offload more stuff into prettify-symbols-mode. Since this involves a "regexp" in a sense, compose-region might be better. In any case, the particular patch overwrites ‘prettify-symbols-alist’, meaning which symbols will be displayed will depend on whether users have their own pretty symbols loaded before the variable is being overwritten. Rasmus -- In theory, practice and theory are the same. In practice they are not