From: Rasmus <firstname.lastname@example.org> To: email@example.com Subject: Re: Support showing stars as pretty bullets Date: Sat, 14 Apr 2018 15:10:35 +0200 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <email@example.com> Nicolas Goaziou <firstname.lastname@example.org> writes: > Hello, > > Alex Branham <email@example.com> writes: > >> But then users of global-prettify-symbols-mode don't see the pretty >> symbols in org buffers without knowing about and activating >> org-pretty-mode. Anyway, the attached patch moves it to org-pretty.el. > > [...] > >> I've left it as a defvar since there's no way for us to know about what >> people want prettified where. Hopefully the default >> prettify-symbols-compose-p function does an OK job, but people will have >> to modify that if they customize org-pretty-alist anyway. > > I think there's a misunderstanding. To me, `prettify-symbols-mode' is > the plumbing. Org Pretty users should not have to care about it. > Likewise, when you use Org Bullets, you don't really care about how it > is done internally. > > As such, we know what people want prettified if we provide the > appropriate defcustom. > > BTW, the plumbing should be `compose-region', not > `prettify-symbols-mode'. IMO ‘prettify-symbols-mode’ is not pluming. It’s an Emacs-wide equivalent of "org-pretty-entities" (or at least the result when that variable is non-nil). IMO, the goal would be to offload more stuff into prettify-symbols-mode. Since this involves a "regexp" in a sense, compose-region might be better. In any case, the particular patch overwrites ‘prettify-symbols-alist’, meaning which symbols will be displayed will depend on whether users have their own pretty symbols loaded before the variable is being overwritten. Rasmus -- In theory, practice and theory are the same. In practice they are not
next prev parent reply other threads:[~2018-04-14 13:10 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-01 20:59 Alex Branham 2018-04-02 18:47 ` Nicolas Goaziou 2018-04-03 0:41 ` Alex Branham 2018-04-03 1:11 ` William Denton 2018-04-03 6:39 ` Nicolas Goaziou 2018-04-03 14:30 ` Alex Branham 2018-04-03 20:33 ` Nicolas Goaziou 2018-04-04 22:14 ` Alex Branham 2018-04-05 12:50 ` Nicolas Goaziou 2018-04-10 16:00 ` Alex Branham 2018-04-14 10:20 ` Nicolas Goaziou 2018-04-14 13:10 ` Rasmus [this message] 2018-04-06 20:22 ` Rasmus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: Support showing stars as pretty bullets' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).