From: Kyle Meyer <firstname.lastname@example.org> To: Clemens <email@example.com> Cc: firstname.lastname@example.org Subject: Re: [PATCH] Use completing-read-multiple for org-set-tags-command Date: Thu, 23 Jul 2020 00:37:42 -0400 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> Clemens writes: > Now that I know that completion works for multiple tags with default > completion I'm unsure if it is worth to proceed with this. I wondered > how this would go unnoticed for such a long time in org and now I know > that the failure was on my part. On the other hand switching to > `completing-read-multiple` would improve the situation for completion > frameworks which handle it correctly and would also be more idiomatic > for this use case. Yeah, I'm also undecided. I'm open to the idea of moving from org-tags-completion-function to crm for the reason you give, but, with any proposal for that, I think it'd be important to see an inspection of the current call sites (only a handful) and an analysis of whether we can retain the current behavior. Then again, this isn't the only place that passes a function for completing-read's COLLECTION argument: there's also org-agenda-filter-completion-function. At a glance I think it would be harder to replace with crm. But perhaps we could at least avoid some confusion by explicitly documenting spots where completion frameworks may interact with the intended completion functionality.
prev parent reply other threads:[~2020-07-23 4:38 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-19 12:49 Clemens 2020-07-19 14:26 ` Clemens 2020-07-19 14:58 ` Clemens 2020-07-19 14:59 ` Clemens 2020-07-20 3:23 ` Kyle Meyer 2020-07-20 6:03 ` Clemens 2020-07-22 4:26 ` Kyle Meyer 2020-07-22 7:04 ` Clemens 2020-07-22 7:16 ` Clemens 2020-07-22 12:37 ` Clemens 2020-07-23 4:37 ` Kyle Meyer [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] Use completing-read-multiple for org-set-tags-command' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).