From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CE7tJfs6pV9TbQAA0tVLHw (envelope-from ) for ; Fri, 06 Nov 2020 12:00:59 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id uPzxIfs6pV87EQAA1q6Kng (envelope-from ) for ; Fri, 06 Nov 2020 12:00:59 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3DE119403A9 for ; Fri, 6 Nov 2020 12:00:59 +0000 (UTC) Received: from localhost ([::1]:37578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kb0QL-00050g-4n for larch@yhetil.org; Fri, 06 Nov 2020 07:00:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb0PS-0004yV-Ej for emacs-orgmode@gnu.org; Fri, 06 Nov 2020 07:00:02 -0500 Received: from mout02.posteo.de ([185.67.36.66]:51697) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kb0PP-0003Ec-Oi for emacs-orgmode@gnu.org; Fri, 06 Nov 2020 07:00:01 -0500 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 0276A2400FD for ; Fri, 6 Nov 2020 12:59:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1604663996; bh=VKejcscYxyqWg5nVf6jQNLoM5hucprHzBCRXdRYZVVk=; h=From:To:Cc:Subject:Date:From; b=FZ7qKntJwriheml4qPrCHx6sb6Sjs5X+VIO/WVT1XCui9mM8IIRj+fFWSALcxx9wb YBUyI+ukeVTKNfC+0A6WA37eqrpbZohu2keo4ADlMxumdglAJ4/tUzCGBFjUa5tdFC uAZsSEylrVBr0N8E7G1/SNIg+eksozavBKhEFlIn0tZgbvjeBCaquZGPFz2aBWpGPc gXGMEWiz7whZWJwtKZGSFEkV/iodV1M9vE5Syi9d5NKfuvbPzu6HHSQM+WRSsxwmtk qY0hhSNANTt1U1cUmCmQ79IFHDdGlWNRl2mRUJlfsw9QT9H/bHIoa+FVm26gFJ1WRK rMuboNDT2cb3w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CSJpz1zgLz9rxq; Fri, 6 Nov 2020 12:59:55 +0100 (CET) References: <87lffi7ou7.fsf@posteo.de> <87d00rnh46.fsf@kyleam.com> User-agent: mu4e 1.5.5; emacs 28.0.50 From: Titus von der Malsburg To: Kyle Meyer Subject: Re: [PATCH] lisp/org.el: Use `org-document-info' face for subtitles In-reply-to: <87d00rnh46.fsf@kyleam.com> Date: Fri, 06 Nov 2020 12:59:49 +0100 Message-ID: <87a6vu8zm2.fsf@posteo.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=malsburg@posteo.de; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/06 06:59:56 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.de header.s=2017 header.b=FZ7qKntJ; dmarc=pass (policy=none) header.from=posteo.de; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: -1.71 X-TUID: +5tDXvVLXJtb --=-=-= Content-Type: text/plain On 2020-11-06 Fr 07:18, Kyle Meyer wrote: > Titus von der Malsburg writes: > >> Subject: [PATCH] lisp/org.el: Use face org-document-info for subtitle >> >> * lisp/org.el: The value for the #+subtitle: property is now displayed >> with face `org-document-info' instead of `org-meta-line'. >> >> Like the title, author, e-mail, date, the subtitle is information >> that is displayed in the exported document. > > Makes sense to me, and I guess it was left out just because #+subtitle > wasn't around until v8.3. > >> --- >> lisp/org.el | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lisp/org.el b/lisp/org.el >> index 03df139fb..27f09645b 100644 >> --- a/lisp/org.el >> +++ b/lisp/org.el >> @@ -5307,7 +5307,7 @@ by a #." >> (min (point-max) end-of-endline)) >> '(face org-block-end-line))) >> t)) >> - ((member dc1 '("+title:" "+author:" "+email:" "+date:")) >> + ((member dc1 '("+title:" "+subtitle:" "+author:" "+email:" "+date:")) >> (org-remove-flyspell-overlays-in >> (match-beginning 0) >> (if (equal "+title:" dc1) (match-end 2) (match-end 0))) > > Please also update org-document-info-keyword's docstring. Done. I also updated the docstring for `org-document-info'. See attached patch. Titus --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-lisp-org.el-Display-subtitle-lines-with-document-inf.patch >From 3d27f195a635f9ef8cbf43e1549663bef447c8fa Mon Sep 17 00:00:00 2001 From: Titus von der Malsburg Date: Tue, 3 Nov 2020 10:32:57 +0100 Subject: [PATCH] lisp/org.el: Display subtitle lines with document info faces * lisp/org.el: The #+SUBTITLE: keyword is now displayed with `org-document-info-keyword' and its value with `org-document-info' (instead of `org-meta-line'). Like the title, author, e-mail, date, the subtitle is information that is displayed in the exported document, not meta information. --- lisp/org-faces.el | 8 +++++--- lisp/org.el | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lisp/org-faces.el b/lisp/org-faces.el index 94b283ad6..2f3273f55 100644 --- a/lisp/org-faces.el +++ b/lisp/org-faces.el @@ -414,12 +414,14 @@ changes." '((((class color) (background light)) (:foreground "midnight blue")) (((class color) (background dark)) (:foreground "pale turquoise")) (t nil)) - "Face for document date, author and email; i.e. that which -follows a #+DATE:, #+AUTHOR: or #+EMAIL: keyword." + "Face for document subtitle, date, author and email; i.e. that +which follows a #+SUBTITLE:, #+DATE:, #+AUTHOR: or #+EMAIL: +keyword." :group 'org-faces) (defface org-document-info-keyword '((t :inherit shadow)) - "Face for #+TITLE:, #+AUTHOR:, #+EMAIL: and #+DATE: keywords." + "Face for #+TITLE:, #+SUBTITLE:, #+AUTHOR:, #+EMAIL: and +#+DATE: keywords." :group 'org-faces) (defface org-block `((t :inherit shadow diff --git a/lisp/org.el b/lisp/org.el index 9a13f03d6..89cb09fe1 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -5307,7 +5307,7 @@ by a #." (min (point-max) end-of-endline)) '(face org-block-end-line))) t)) - ((member dc1 '("+title:" "+author:" "+email:" "+date:")) + ((member dc1 '("+title:" "+subtitle:" "+author:" "+email:" "+date:")) (org-remove-flyspell-overlays-in (match-beginning 0) (if (equal "+title:" dc1) (match-end 2) (match-end 0))) -- 2.25.1 --=-=-=--