From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id MJp3O7i3hmBodgAAgWs5BA (envelope-from ) for ; Mon, 26 Apr 2021 14:53:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 4I0yN7i3hmDURAAA1q6Kng (envelope-from ) for ; Mon, 26 Apr 2021 12:53:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6271DA0CC for ; Mon, 26 Apr 2021 14:53:12 +0200 (CEST) Received: from localhost ([::1]:43608 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb0jf-00006F-8T for larch@yhetil.org; Mon, 26 Apr 2021 08:53:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb0iD-0007yQ-2H for emacs-orgmode@gnu.org; Mon, 26 Apr 2021 08:51:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55526) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb0iC-0002tT-Qg; Mon, 26 Apr 2021 08:51:40 -0400 Received: from [78.194.183.21] (port=36476 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1lb0iA-0007U5-ST; Mon, 26 Apr 2021 08:51:39 -0400 Received: by guerry (Postfix, from userid 1000) id 8FB8E1A60F1F; Mon, 26 Apr 2021 14:51:36 +0200 (CEST) From: Bastien To: No Wayman Subject: Re: Bug: [PATCH] define-minor-mode: prefer keyword args [9.4.5 (9.4.5-ga02a3b @ /home/n/.emacs.d/straight/build/org-plus-contrib/)] In-Reply-To: <87y2d5mde2.fsf@gmail.com> (No Wayman's message of "Mon, 26 Apr 2021 08:32:54 -0400") Organization: GNU References: <87y2d5mde2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Mon, 26 Apr 2021 14:51:36 +0200 Message-ID: <87a6plus2v.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619441592; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=gEe3ewbeZ8zoVzt5FSgQQiQU1LSsO+GLaYRTxQ0LnPg=; b=apK9Y3Rmc1QCro9YiqYNzzEfp8PGMjT/omwD6Ct3/rDWsYm+hG7ZuoUg2paRok2dLuX67q dLEOe1qZ3u5hXQHV5SqYt3LG0w3zoQRWlB/P36zrCfIY22PM70jNPaT9DPakZURXtm/0iw 4gAUlTxxTlrJgiEaUtZL4Gegz8/i6wPdZFoY8HrA0Ao5cfOxaKTfrUy3MXh1GMl6lYjZsk kmBZ6inkrh7WmLP1K8KXYRns2Wy5pjVo0EMdvt7ws8u1i1XrSwQvDrZ1LG3cZKLzz0Ww7b LMS5Mp8pKVSpC3VGkTtvC2Hs6q5NE+73NcPqdtKCyBxXfOoOLK/qQ8FVm4OHkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619441592; a=rsa-sha256; cv=none; b=DtcWgij8oDisDPv5iTJokQj/Ro5rpyShDCLtxJQxVLmnSnq5gNcq9oz42tBLEL8i8Bv2Jk vcBFN+ZrRts+DO9jFqn3PTX9xkhUjDphs8AocxmlbxnXiKdKnLnj0PPiAvk65boFyjk+oS yMZtzqF+nvsXHVjAZ1sYOD6e/neCmHb1aaKtfMQoz3guWKTfyFG8dssFwebCUEXfleCZbV TZyT++8HhJU/g8RFtdWaLdLhtn34i/S8SPuUZZFNr1ZrB0Dv3cSA261xy52cZ9gOln4N2A tAQbsijTwHtiAB5Z+nvxd/Amgaz1a5FBxEXhwUanKgqU82PsKuOUqtz9MbKgnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.95 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 6271DA0CC X-Spam-Score: -2.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: 3zShEEnAVi3a Hi, thanks for the patch, we do indeed need to move forward for this. Could you propose the patch against the master branch (not the maint branch, since this is not a bugfix) and perhaps fix *all* warnings? Also, here the preferred format for the commit message: * lisp/org-table.el (org-table-header-line-mode) (org-table-follow-field-mode): Migrate minor mode definitions from positional arguments to keyword args. * lisp/org-src.el (org-src-mode): Ditto. * lisp/org-list.el (org-list-checkbox-radio-mode): Ditto. Don't worry too much about it, I can always rearrange it. Thanks!