From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id RmRzDHZvjWByigAAgWs5BA (envelope-from ) for ; Sat, 01 May 2021 17:10:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id cFozB3ZvjWDuRgAA1q6Kng (envelope-from ) for ; Sat, 01 May 2021 15:10:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9B6841D426 for ; Sat, 1 May 2021 17:10:45 +0200 (CEST) Received: from localhost ([::1]:41426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcrGW-00082e-CS for larch@yhetil.org; Sat, 01 May 2021 11:10:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcrFs-00082U-3r for emacs-orgmode@gnu.org; Sat, 01 May 2021 11:10:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44759) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcrFr-00081H-44; Sat, 01 May 2021 11:10:03 -0400 Received: from [78.194.183.21] (port=49986 helo=guerry) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1lcrFp-0001Bo-Rv; Sat, 01 May 2021 11:10:02 -0400 Received: by guerry (Postfix, from userid 1000) id 57CDD1A60EE4; Sat, 1 May 2021 17:09:54 +0200 (CEST) From: Bastien To: =?utf-8?Q?S=C3=A9bastien?= Miquel Subject: Re: [PATCH] ob-tangle.el: Speed up tangling In-Reply-To: <9dfb44d3-0c4a-6a66-0efa-c70e9434ee5e@posteo.eu> (=?utf-8?Q?=22S=C3=A9bastien?= Miquel"'s message of "Wed, 21 Apr 2021 06:33:21 +0000") Organization: GNU References: <57480e77-024a-adcc-ec9a-c20b84ac762a@posteo.eu> <9dfb44d3-0c4a-6a66-0efa-c70e9434ee5e@posteo.eu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Sat, 01 May 2021 17:09:54 +0200 Message-ID: <87a6pe4hj1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Gillespie , emacs-orgmode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619881845; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=AkV0hNEqweNJeP9+FsGbg4nkcY9tPcD2R+zWeQHMGyY=; b=GWHHbEbpVDgrUSZuqrtMGkIlZv/VPEwmcb18e32vIlEGoOgxfUKxaXeNtJyKKpKx2YLWJP Bp7L4ZM45gOcYEMaGBbFp2Upj1moKMG5Q1EK60LchX3B8VMDTO9g3tGd4f9Lt2tw3rzhfi aMSLarwac0sx9VNL1W6h7q4nW0yVf+vMuV397NSn5e+Y1xCQjN21sbel3lg3JuYJJrDK0U ENoxO4+h+nbOk/FqC11P7vMXDdu+lHLlxQX42X5KKtHWIoRyd+DBbqlpzD6Zi7cWqYlzwB CroK7L/am2ot2sD0fSCuClKxCCb06/J79wojVLQN0KLmRrij3NC9AHGC7g9TrQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619881845; a=rsa-sha256; cv=none; b=UTAwj02KfKIEiNG6cwK40FGelY//Sl+1mXLqa1w4LEyEgfTtcJOALiWSkghLGb7njCoFAZ BdadN/C0d5eAKCy8pnVywdXoeSPsedfzU3aJU+MTg28aYItv/x+89B4cVnQ9b13VWU4qN5 OWjQAVUlqFQPHbXfRXguJD3Sumb+caynVXB71k44ny9jocg5TcmaabWykdrg2rlaBfJDWI pP78GNLC8mSBVwWbKFLbY66Qbkga1LYF9QcxZLs4u4OZBn8EWEnWn9jceJSn+IBYQ8ODEd exlMDiSADDYDB5Ay9IvLVWu5KDnoK6OiJa/agJQEEqNMDTAxXE7elXkAMmmtXg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.96 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 9B6841D426 X-Spam-Score: -2.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: ZeDfslXHecJb Hi S=C3=A9bastien, thanks for the patch! I applied against master and tested it. The compiler is complaining with In toplevel form: ob-tangle.el:196:1: Warning: Variable =E2=80=98modes=E2=80=99 left uninit= ialized Also, it breaks these two tests for me: 2 unexpected results:=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20 FAILED ob-tangle/block-order=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20 FAILED ob-tangle/continued-code-blocks-w-noweb-ref Let me know if you manage to pass all the test (or fix them...) and silent the warning. Thanks! --=20 Bastien