From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id GEIWK7gij2F7IgAAgWs5BA (envelope-from ) for ; Sat, 13 Nov 2021 03:28:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EFrJJrgij2GoeAAAB5/wlQ (envelope-from ) for ; Sat, 13 Nov 2021 02:28:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E92B413D51 for ; Sat, 13 Nov 2021 03:28:03 +0100 (CET) Received: from localhost ([::1]:45726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mlilu-0001l1-4X for larch@yhetil.org; Fri, 12 Nov 2021 21:28:02 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mlilT-0001kf-90 for emacs-orgmode@gnu.org; Fri, 12 Nov 2021 21:27:35 -0500 Received: from [2607:f8b0:4864:20::f34] (port=36726 helo=mail-qv1-xf34.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mlilR-0004FA-F2 for emacs-orgmode@gnu.org; Fri, 12 Nov 2021 21:27:35 -0500 Received: by mail-qv1-xf34.google.com with SMTP id kl8so2991087qvb.3 for ; Fri, 12 Nov 2021 18:27:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:user-agent:from:to:subject:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=L893OCH+AG6iskAa7Af97upaHSYtVqlUtvNjTPp1ziw=; b=R90/mQ5pjNIB06rA/iFt29ZK3zEwCAOhP9jkNiBXF61lDbtzZ6AyOuDT9fpZpW/Rzc Im+zHyWrKaRuTZ83ty9R0mUXdh6nVT9JnmDdLnoWPIELss608l13VdP4VXItTeoRcvpa oE/zw32prV9YzaqRvbP9Cdq4poLOA8/dQ/70M1+T5M2N+ZxBASLX6xXSZO+yP10YoFq3 7Uehc6+Ee91vIKxHqW3l9MIhLcxOt+hVhyg8fTHJ6k+Fn4IrwLf3FRKN/i6PR0L2ivCy HeFrqAEyaNK8fAOJKWWqu6X+ZZgT8+YKzNGDE3HxcMuL17kdavmSA0Nu8yYFLW8Xwdvs OSuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:references:user-agent:from:to:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=L893OCH+AG6iskAa7Af97upaHSYtVqlUtvNjTPp1ziw=; b=3JkJmvVSql1KuohTcY9cyW8/xMShWG2MFIp9T+sP5TVv9Gk+GhPM7IibHcQQ7QB1nl WH/OLHkA1OC76aT79IQ+mehlOiy31GDPKPNoffWRSGVduRzf+/Wx6yzbxUw9yxbIsRg4 P3APnQO8HSvEoI4lWk/cKGE+h5ZuBRw5UuQ4XMRSn8B6gUJqwWFkVuFiNkf2jvWgSOJW LzP0vamgZQ6VzsR27J9N2/8zFYGvwzNX5FDEKYQ8aDcFIeQ8RtjKHIDN5u5c+jFuV2// jaCzxuseEuCrMYxe880a0ttyr/UUn9H9+xIZTS4cx+xctF1XmhQibR/PSgF42yc1Obqj 9pDg== X-Gm-Message-State: AOAM53279lyR4VpC3Hru6CwfLcgwJhm21pKFzzxGzt+5zpOMjqRc3DJI cZO6U8fs4IuJjEEWqAbNEohx4tgNN8o= X-Google-Smtp-Source: ABdhPJxm0X3+lshIW++wr32TcBtlIE33lkY77wMSNbQlH0Zymt1DFjNnvUB97iaOBRZcLJsrFNXG1w== X-Received: by 2002:a17:903:11cc:b0:13f:ecf7:22c7 with SMTP id q12-20020a17090311cc00b0013fecf722c7mr13456939plh.5.1636769963495; Fri, 12 Nov 2021 18:19:23 -0800 (PST) Received: from dingbat (2001-44b8-31f2-bb00-2d9c-a7a1-3a0a-38ad.static.ipv6.internode.on.net. [2001:44b8:31f2:bb00:2d9c:a7a1:3a0a:38ad]) by smtp.gmail.com with ESMTPSA id k14sm8193783pff.6.2021.11.12.18.19.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 18:19:23 -0800 (PST) References: User-agent: mu4e 1.7.5; emacs 28.0.60 From: Tim Cross To: emacs-orgmode@gnu.org Subject: Re: whitespace in org source files Date: Sat, 13 Nov 2021 13:15:15 +1100 In-reply-to: Message-ID: <87a6i8n6fr.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::f34 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::f34; envelope-from=theophilusx@gmail.com; helo=mail-qv1-xf34.google.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1636770484; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=L893OCH+AG6iskAa7Af97upaHSYtVqlUtvNjTPp1ziw=; b=UaDqol9wcDlg1tuJ+/qWXEsxaKC5WXyzsJlSDCnB65vMa204hOeUB9YaFsoGFPrA2fWrdk b4q393to04PjSm5V8z/agl9Ev4uVbyMZ2oq22kIMaEsl2HWsSJMyG0NTcKAS2oj5xiD4GG 7Pzw1UrxNuSCi7qRigbfmmWi9NsH+lwLwHYIv91kTkkPq48c2GLPC+/WdNTsFt23FaIalC D5ywtsE/4ryQtQ3bxr1rtuJ6OilBTaZfhkmMitnfUsz8q4FA85z6I/uXUwSAmVdMfE5lrg emO7SEjsCeXRoFmy+HW9nPabEvPUYpEsIf3o2vSeRR95KU5Hd0f4CuR+nNFpHQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1636770484; a=rsa-sha256; cv=none; b=L8Umau7iP1viuMw9aWiQWTTqz7/U2qKCqLhAWe1OxNUQfw5gGgTrfqJ/j0+1rTXwUTs709 wbblwL6zA1L7J8iJwmPCfWNmPV13cjCq0xe/aJywltMV5P+CdPdzoEm2/gZv/6imvunYuy 53H/cvnEVCEpw3NIQmAi84Z1IX2Fjp5HHm5HO9OA31VK26t8Yip051WmYeQowSk8YxUiAn L4MmZj89M/mBlJ4tGRB8DY+y93H5hcGLHIjo87yx0zDT6PJ7F7Wu6HrJTK6uca7BboNMP1 66cZc47Bw24aCmfpOX6frAW7LieZMcRe8M6A44AiWKcwZ//1k3BsMfvdfm2N/Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="R90/mQ5p"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -3.43 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="R90/mQ5p"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: E92B413D51 X-Spam-Score: -3.43 X-Migadu-Scanner: scn1.migadu.com X-TUID: mFFFcALpXkEx excalamus--- via "General discussions about Org-mode." writes: > I'm hacking on ob-shell.el and I see that the source has mixed tabs and s= paces. > If I were to contribute changes, would it be an issue if tabs were conver= ted to > whitespace? > > I've not used the email contribution style before and have had whitespace= issues > in the past with GitHub PRs.=C2=A0 I typically run whitespace-cleanup wit= h the > before-save-hook which changes tabs to spaces. It is usually a bad idea to change whitespace in this manner. It will not improve readibility but will cause lots of change which will likely make merging and tracking/reviewing changes harder than necessary. Ideally, git itslef would be configured to deal with this automatically. Unfortunately, the tab v space arguments can often reach the level of religious war and represents something which is difficult to get consensus on. My recommendation would be to use dir local variable settings to make Emacs use the same formatting style (i.e. with tabs) for working with org-mode sources if your normal/wider preference is just for spaces. this will prevent Emacs from making unnecessary whitespace changes.